Open
Conversation
Contributor
Author
|
Hi @matthewdevenny, could you help to take a look at this PR? Thanks! |
Signed-off-by: Daniel Shuy <daniel_shuy@hotmail.com>
Contributor
Author
|
Hi @matthewdevenny, could you help to take a look at this PR? Thanks! |
Contributor
Author
|
Hi @matthewdevenny, could you help to take a look at this PR? |
This was referenced Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config-mergeuses YAML.stringify() to format the merged output as YAML.While
YAML.stringify()outputs YAML version 1.2 by default (https://eemeli.org/yaml/#document-options), the merged output may be consumed/parsed by other applications that expect YAML version 1.1. This is normally not an issue, except when it comes toyes/nostrings. By default,YAML.stringify()formats strings unquoted. YAML version 1.2 parses unquotedyes/nostrings as strings, while YAML version 1.1 parses unquotedyes/nostrings astrue/falsebooleans (https://eemeli.org/yaml/#version-differences).An easy solution is to configure
YAML.stringify()to double-quote all strings by default, by settingdefaultStringTypetoQUOTE_DOUBLE(https://eemeli.org/yaml/#tostring-options). This will have no impact on YAML version 1.2 parsers, but fixes the issue with YAML version 1.1 parsers when it comes toyes/nostrings.