Add routeProps param to Location.toRoute()#7
Open
Konstantinov-Innokentii wants to merge 1 commit intobradstiff:masterfrom
Open
Add routeProps param to Location.toRoute()#7Konstantinov-Innokentii wants to merge 1 commit intobradstiff:masterfrom
Konstantinov-Innokentii wants to merge 1 commit intobradstiff:masterfrom
Conversation
Facing the same issue, Please merge this quickly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case, when location objects and matching components are stored in array of objects like this:
let routes = [{location: Location, component: Component}, ...]and used in this way:
I get Warning "Each child in an array or iterator should have a unique "key" prop". To avoid it I should pass key prop to Route. For this purpose I added routeProps param to Location.toRoute().
Usage is: