Skip to content

Allow setting embedding model in AnswerCorrectness #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Qard merged 1 commit into from
Jan 14, 2026
Merged

Allow setting embedding model in AnswerCorrectness #162

Qard merged 1 commit into from
Jan 14, 2026
+212 −29

Conversation

@Qard
Copy link
Contributor

@Qard Qard commented Jan 13, 2026

Fixes #140

@Qard Qard requested review from ankrgyl and ibolmo January 13, 2026 00:13
@Qard Qard self-assigned this Jan 13, 2026
@Qard Qard added the enhancement New feature or request label Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

Braintrust eval report

Autoevals (configurable-answer-correctness-embedding-model-1768353136)

Score Average Improvements Regressions
NumericDiff 71.5% (-1pp) 2 🟢 4 🔴
Time_to_first_token 1.37tok (+0.06tok) 40 🟢 79 🔴
Llm_calls 1.55 (+0) - -
Tool_calls 0 (+0) - -
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 279.25tok (+0tok) - -
Prompt_cached_tokens 0tok (+0tok) - -
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 19.3tok (+0tok) - -
Completion_reasoning_tokens 0tok (+0tok) - -
Total_tokens 298.54tok (+0tok) - -
Estimated_cost 0$ (+0$) - -
Duration 3.02s (-0.01s) 139 🟢 80 🔴
Llm_duration 2.62s (-0.07s) 91 🟢 28 🔴

ibolmo
ibolmo approved these changes Jan 13, 2026
View reviewed changes
@Qard Qard force-pushed the configurable-answer-correctness-embedding-model branch 2 times, most recently from 374cba4 to c5c2ac7 Compare January 13, 2026 21:20
@Qard Qard force-pushed the configurable-answer-correctness-embedding-model branch 2 times, most recently from 40898ef to 5b4e619 Compare January 14, 2026 01:11
@Qard Qard merged commit 71a3cf4 into main Jan 14, 2026
14 checks passed
@Qard Qard deleted the configurable-answer-correctness-embedding-model branch January 14, 2026 03:37
@github-actions
Copy link

github-actions bot commented Jan 14, 2026 •
edited
Loading

Braintrust eval report

Autoevals (main-1768361867)

Score Average Improvements Regressions
NumericDiff 71.5% (-1pp) 2 🟢 4 🔴
Time_to_first_token 1.37tok (+0.05tok) 42 🟢 74 🔴
Llm_calls 1.55 (+0) - -
Tool_calls 0 (+0) - -
Errors 0 (+0) - -
Llm_errors 0 (+0) - -
Tool_errors 0 (+0) - -
Prompt_tokens 279.25tok (+0tok) - -
Prompt_cached_tokens 0tok (+0tok) - -
Prompt_cache_creation_tokens 0tok (+0tok) - -
Completion_tokens 19.3tok (+0tok) - -
Completion_reasoning_tokens 0tok (+0tok) - -
Total_tokens 298.54tok (+0tok) - -
Estimated_cost 0$ (+0$) - -
Duration 2.73s (+0.27s) 86 🟢 132 🔴
Llm_duration 2.8s (+0.06s) 46 🟢 72 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibolmo ibolmo ibolmo approved these changes

@ankrgyl ankrgyl Awaiting requested review from ankrgyl

Assignees

@Qard Qard

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set embedding model in AnswerCorrectness scorer

3 participants

@Qard @ibolmo