style: simplify some statements for readability#405
Open
hamirmahal wants to merge 1 commit intobrave:masterfrom
Open
style: simplify some statements for readability#405hamirmahal wants to merge 1 commit intobrave:masterfrom
hamirmahal wants to merge 1 commit intobrave:masterfrom
Conversation
hamirmahal
commented
Dec 1, 2024
Author
hamirmahal
left a comment
hamirmahal
left a comment
There was a problem hiding this comment.
This shouldn't result in any user-facing changes.
The goal of this pull request is to improve code maintainability and developer productivity.
0ex-d
approved these changes
Dec 5, 2024
0ex-d
left a comment
0ex-d
left a comment
There was a problem hiding this comment.
This is good work! @antonok-edm can take a look please
Author
|
@antonok-edm are you open to merging this if I fix the merge conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #404