Skip to content

Comments

Add 'Dates' parameter to tradeStats and dailyStats functions#116

Open
evgeniavolkova wants to merge 6 commits intobraverock:masterfrom
evgeniavolkova:dailystats_dates
Open

Add 'Dates' parameter to tradeStats and dailyStats functions#116
evgeniavolkova wants to merge 6 commits intobraverock:masterfrom
evgeniavolkova:dailystats_dates

Conversation

@evgeniavolkova
Copy link

No description provided.

@joshuaulrich
Copy link
Collaborator

joshuaulrich commented Feb 16, 2022

Hi! Thanks for your work to make this change. Could you please keep them all in one PR? You've opened and closed 2 other PRs for the same purpose (#114, #115), and they have the same commits.

You can keep adding new commits to this PR if you find other changes you need to make. There's no reason to open a new PR with the same commits if you only need to add some new commits... to fix build errors, for example.

@evgeniavolkova
Copy link
Author

evgeniavolkova commented Feb 16, 2022 via email

@joshuaulrich
Copy link
Collaborator

No worries! We can re-open this one if you accidentally close it.

@joshuaulrich joshuaulrich mentioned this pull request Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants