Add 'Dates' parameter to tradeStats and dailyStats functions#116
Open
evgeniavolkova wants to merge 6 commits intobraverock:masterfrom
Open
Add 'Dates' parameter to tradeStats and dailyStats functions#116evgeniavolkova wants to merge 6 commits intobraverock:masterfrom
evgeniavolkova wants to merge 6 commits intobraverock:masterfrom
Conversation
Collaborator
|
Hi! Thanks for your work to make this change. Could you please keep them all in one PR? You've opened and closed 2 other PRs for the same purpose (#114, #115), and they have the same commits. You can keep adding new commits to this PR if you find other changes you need to make. There's no reason to open a new PR with the same commits if you only need to add some new commits... to fix build errors, for example. |
Author
|
Hi!
Sorry, it was an accident. Won't do it again.
ср, 16 февр. 2022 г., 19:44 Joshua Ulrich ***@***.***>:
… Hi! Thanks for your work to make this change. Could you please keep them
all in one PR? You've opened and closed 2 others for the same purpose (
#114 <#114>, #115
<#115>), and they have the same
commits.
You can keep adding new commits to this PR if you find other changes you
need to make. There's no reason to open a new PR with the same commits if
you only need to add some new commits.
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGC4WMDW2Z2IGBSGODD5C43U3PIAPANCNFSM5OSETGSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
No worries! We can re-open this one if you accidentally close it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.