Toggle the use of use imperativeHandle#167
Merged
break-stuff merged 3 commits intobreak-stuff:mainfrom May 8, 2025
Merged
Conversation
added 2 commits
May 8, 2025 12:53
…s opt-in or opt-out.
… use of `useImperativeHandle`.
break-stuff
reviewed
May 8, 2025
Owner
|
I think this can be simplified. By updating the ref: (node) => {
ref.current = node; // Assign the DOM node to the internal ref
if (typeof forwardedRef === "function") {
forwardedRef(node); // Support callback refs
} else if (forwardedRef) {
forwardedRef.current = node; // Support object refs
}
},That should resolve the ref mapping issue and we should be able to remove the |
Author
|
I can update the commit removing the |
Owner
|
Please, go ahead. You've done most of the leg work already. 😄 |
…implementation and reduced the solution to a simple `ref` update function.
break-stuff
approved these changes
May 8, 2025
Owner
|
@dutchcelt The fix has been deployed under v1.7.1. I appreciate your help on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to allow users to create wrappers with a specific behavior for
useRefby toggling the application of 'useImperativeHandle'.This PR does three things:
withImperativeHandleuseImperativeHandlefeature so that users can retrieve the custom element fromref.current.useImperativeHandlewhen used, now gets a 'customElement' property as a fallback to retrieve the custom element.