fix: add browser-safe UMD bundle for bower/script-tag users#33
Merged
fix: add browser-safe UMD bundle for bower/script-tag users#33
Conversation
The rollup build marked 'debug' as external, which works for npm/webpack users but breaks bower/script-tag users who don't have debug available globally. Added .bundle.js and .bundle.min.js variants that inline debug's browser build using rollup's browser resolution. These bundles only require 'angular' as an external dependency. Existing builds unchanged: - angular-simple-logger.js — UMD with debug external (npm users) - angular-simple-logger.esm.js — ES module (bundler users) - angular-simple-logger.light.js — no debug dependency - angular-simple-logger.bundle.js — NEW: debug bundled (bower users) Fixes #32
nmccready
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Problem
v0.2.1 marked
debugas an external dependency in the rollup UMD build. This works for npm/webpack users but breaks bower/script-tag users (like angular-google-maps consumers) becausedebugisn't available globally.Fix
Added
.bundle.jsand.bundle.min.jsvariants that inline debug's browser build using rollup'sresolve({ browser: true }). These bundles only requireangularas an external dependency — no Node.js builtins, no missing modules.Builds (all included in npm package)
angular-simple-logger.jsangular-simple-logger.esm.jsangular-simple-logger.light.jsangular-simple-logger.bundle.jsangular-simple-logger.bundle.min.jsTesting
angularexternallynemLoggingmodule registers correctlyWorkaround for #32 users right now
Pin to
0.1.7or use the.lightbuild which has no debug dependency.