chore: Phase 3 cleanup — remove legacy JS files#85
Merged
Conversation
Delete all legacy JavaScript files that were superseded by the TypeScript rewrite in Phase 2: - Remove JS test runners: t/cli.js, t/include.js, t/replaceEnv.js, t/unit.js, t/tests/extendEnv.js - Remove legacy JS source: index.js, lib/*.js, lib/include/*.js - Remove bin/cli.js shim (package.json bin already points to dist/cli.js) - Update test/cli.test.ts to reference dist/cli.js instead of bin/cli.js - Update benchmarks/benchmark-runner.js to import from dist/ All test fixture data in t/tests/, t/includes/, t/fixtures/, and t/regression-fixtures/ is preserved (used by new TS tests). 197 tests pass. Closes #80, closes #81, closes #82, closes #83
Collaborator
|
Whats the total coverage at? |
Author
✅ QA PASSAll verification checks passed:
Minor note (non-blocking): README has 4 cosmetic references to Verdict: Ready to merge. Issue #84 can be closed. |
nmccready
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all legacy JS source files, test runners, and bin/cli.js shim superseded by the TypeScript rewrite.
Deleted: t/cli.js, t/include.js, t/replaceEnv.js, t/unit.js, t/tests/extendEnv.js, index.js, lib/.js, lib/include/.js, bin/cli.js
Updated: test/cli.test.ts and benchmarks/benchmark-runner.js to reference dist/
Preserved: All fixture data in t/tests/, t/includes/, t/fixtures/, t/regression-fixtures/
Verified: npm run build ✅ | npm test ✅ (197/197 pass)
Closes #80, closes #81, closes #82, closes #83