BRNGG-36274-Add integration tests for parse error handling#105
Merged
ormelaver-cyber merged 6 commits intomasterfrom Feb 15, 2026
Merged
BRNGG-36274-Add integration tests for parse error handling#105ormelaver-cyber merged 6 commits intomasterfrom
ormelaver-cyber merged 6 commits intomasterfrom
Conversation
ramhr
approved these changes
Feb 10, 2026
shamil
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important Note
After further discussion, it was decided that we REMOVE the
throw errorwhen we get aSyntaxError. This was a bug that we initially decided to leave as is.Apparently
amqplib, which is the one that eventually callsconsumeFunc(viachannel.consume(queue, consumeFunc, { noAck: false })), does notawaitso there is no option to catch the error that we throw.Now if clients want to handle the error, they must register to the
afterProcessMessagecallback that is invoked in_rejectMessageAfterProcessAdd integration tests for consumer parse error handling