Skip to content

feat: Add the ability to pass a requests Session to Client #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coreone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add the ability to pass a requests Session to Client #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cert_manager/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ def __init__(self, **kwargs):
auth_url: The full URL to the Sectigo OAuth2 token endpoint; the default is "https://auth.sso.sectigo.com/auth/realms/apiclients/protocol/openid-connect/token"
client_id: The Client ID to use for OAuth2 authentication
client_secret: The Client Secret to use for OAuth2 authentication
session: A requests.Session object to use instead of creating a new one; the default is None,
which will create a new session
"""
# Initialize class variables
self._base_url = None
Expand All @@ -51,7 +53,8 @@ def __init__(self, **kwargs):
self._user_key_file = None
self._username = None

self._session = requests.Session()
self._session = kwargs.get("session", requests.Session())

# Set the default HTTP headers
self._headers = {
"Accept": "application/json",
Expand Down
Loading