Fix not playing audio on iOS for some local paths#65
Open
t-unit wants to merge 2 commits intobsutton:masterfrom
Open
Fix not playing audio on iOS for some local paths#65t-unit wants to merge 2 commits intobsutton:masterfrom
t-unit wants to merge 2 commits intobsutton:masterfrom
Conversation
Owner
|
@t-unit thanks for the PR. Just a few comments on the state of play. I'm currently on leave and renovating my house. We are currently trying to remove all of the swift/obj-c code from the project by using ffi. I wondering if you would be interested in getting involved in the ffi port? |
Author
|
@bsutton sorry, can't help you at the moment with any coding support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When handing local system paths, a special constructor must be called on
URL. See the official documentation.For example, without this fix
/Users/some-user/Library/Developer/CoreSimulator/Devices/828006A2-398A-40E6-B8C4-10D6974A84EA/data/Containers/Data/Application/005825E6-2EC9-45BD-9F9F-54EE3D3033D8/Library/Application Support/audio/some-audio-filewould result in
nilbeing handed as a URL toAVAudioPlayer.Unfortunately the project did not compile, so I applied some quick fixes as a second commit to this PR to make the project work.
The actual fix can be found in this commit