GRPCGATEWAY-20 match against named URL template slots correctly#21
Open
ndolgov wants to merge 3 commits intobtlines:masterfrom
Open
GRPCGATEWAY-20 match against named URL template slots correctly#21ndolgov wants to merge 3 commits intobtlines:masterfrom
ndolgov wants to merge 3 commits intobtlines:masterfrom
Conversation
saurcery
reviewed
Oct 9, 2018
| while (pathIndex < path.length) { | ||
| val from = pathIndex | ||
|
|
||
| val matcher = matchers(matcherIndex) |
There was a problem hiding this comment.
there is a bug here. in cases when matchers.length < path.length this line will thrown IndexOutOfBoundsException.
|
@ndolgov @btlines @xuwei-k any further interest in getting this PR to master ? Its quite useful feature for RESTful API support imo. Let me know how I can help! |
Author
|
I have a feeling @btlines has abandoned this repo. It's a pity because the idea was intriguing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in a generated Handler