Add support for REST to GRPC header pass through#36
Open
mlangc wants to merge 4 commits intobtlines:masterfrom
Open
Add support for REST to GRPC header pass through#36mlangc wants to merge 4 commits intobtlines:masterfrom
mlangc wants to merge 4 commits intobtlines:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first sketch to adapt the implementation to allow passing through selected headers from REST calls to the corresponding GRPC calls. This PR introduces the environment variable
REST_TO_GRPC_PASS_THROUGH_HEADERSthat can be used to define headers that are passed through unmodified from REST to GRPC metadata.What is still missing is
REST_TO_GRPC_PASS_THROUGH_HEADERSBefore taking care of the remaining issues I would like to hear your feedback though.