Rename ClassLoadingUtil.load(String, Object) to loadFromContext#794
Merged
jbachorik merged 2 commits intojb/configurationsfrom Jan 14, 2026
Merged
Rename ClassLoadingUtil.load(String, Object) to loadFromContext#794jbachorik merged 2 commits intojb/configurationsfrom
jbachorik merged 2 commits intojb/configurationsfrom
Conversation
There was a problem hiding this comment.
Could not review PR. Too many requests in the last 5 minutes.
Max 1 pr 5 minutes. Last review was in btraceio/btrace at Tue, 13 Jan 2026 16:37:32 GMT.
Next review is available in approx 5 minutes.
Upgrade to a premium Reviewabot plan or contact us at support@reviewabot.com to request an exemption.
…usion Co-authored-by: jbachorik <738413+jbachorik@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on provided-style extensions
Rename ClassLoadingUtil.load(String, Object) to loadFromContext
Jan 13, 2026
jbachorik
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ClassLoadingUtilclass had two overloadedloadmethods that dispatch based on static types (ClassLoader vs Object), creating ambiguity when the Object parameter is actually a ClassLoader or null.Changes
load(String className, Object context)→loadFromContext(String className, Object context)to clarify it extracts the ClassLoader from the context object's defining loaderExample
The
load(String, ClassLoader)overload remains unchanged for direct ClassLoader usage.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.