Add FreeBSD Support#1271
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
- Coverage 63.99% 63.97% -0.02%
==========================================
Files 100 100
Lines 6909 6913 +4
==========================================
+ Hits 4421 4422 +1
- Misses 2081 2083 +2
- Partials 407 408 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
What's up with the ARM64 test failing? And I could use some guidance about the local_handler_test failure - I realized I'm actually a bit confused about how this communicates with a local docker engine (docker in docker) -- i.e., what's listening on /var/run/docker.sock in Linux? Is that the same docker that's running the CI container? In FreeBSD, when I'm running docker, I do it in a separate virtual machine under bhyve and use TCP to connect the two. |
|
@hut8 thanks for this!
That seems to be a flake. I can re-kick the CI.
Here is where we initialize the docker connection in the lifecycle: Line 16 in 3c8876c I think it should just work if you've set |
|
@hut8 Have you attempted to build flyctl with this branch? I've tried adding So I'm not sure how to override this dependency with your branch to try building flyctl. |
|
@patmaddox sorry, I'm not sure! I didn't actually get flyctl to build, because I was stuck on the test failures in CI that I couldn't really explain, and now I have loads of dayjob work :) |
Summary
Adds support for FreeBSD
Release notes
lifecyclewill now build on FreeBSD.Related
#1087 - this is rather old, had a lot of conflicts, and probably needs extensive CI tweaking. So I chose to start fresh, but used some parts of this as a starting point, so credit to @quantumsheep
Surprisingly there is no issue that mentions FreeBSD but there should be 😄
Context
I need this because the fly.io CLI depends on this package and I want to be able to run it from FreeBSD.
superfly/flyctl#712