-
Notifications
You must be signed in to change notification settings - Fork 114
Upgrade Go to 1.26.0 #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go to 1.26.0 #1601
Conversation
Co-authored-by: jabrown85 <790999+jabrown85@users.noreply.github.com>
Co-authored-by: jabrown85 <790999+jabrown85@users.noreply.github.com>
|
@copilot the actions are failing on your PR - investigate |
Co-authored-by: jabrown85 <790999+jabrown85@users.noreply.github.com>
Fixed in commit 8478c76. The build failure was caused by a non-constant format string in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Summary
Updates Go toolchain from 1.25.6 to 1.26.0.
go.mod: Go directive updated to 1.26.0acceptance/testdata/launcher/Dockerfile: Base image updated togolang:1.26.0.github/workflows/test-s390x.yml: s390x binary download URL updated to go1.26.0Makefile: Launcher size limit increased from 3MB to 4MB (s390x binary is now 3.1MB; other architectures remain <3MB)platform/files/handle_toml.go: Fixed non-constant format string error - Go 1.26.0 enforces stricter security checks on formatted logging functions, requiring constant format stringsRelease notes
Updated Go to 1.26.0. The launcher binary size limit increased from 3MB to 4MB to accommodate s390x architecture. Fixed format string security issue for Go 1.26.0 compatibility.
Context
Binary sizes post-upgrade:
Go 1.26.0 introduced stricter security checks for formatted logging functions. The code in
platform/files/handle_toml.go:44was passing a non-constant string directly as the format string tologger.Debugf(), which is now flagged as a security issue. This was fixed by using a constant format string ("%s") with the dynamic content as an argument.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.