Reverting the MAC - Address flag code (for now) #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the ci Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
github-actions
bot
added
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we can't verify in our CI tooling that the
MAC addressis configured correctly when running the docker container, the reason for that is because the ubuntu latest runner only supports Docker version 1.43 and we need version 1.44 for this feature. Also, we need to update our Windows runner, currently they support Docker version 1.41.Once our runners are running the expected Docker version, then we can merge this code again, plus the acceptance tests developed in this PR
Documentation
Related