Add try-always pull policy and unit tests#2347
Draft
kunalvirwal wants to merge 2 commits intobuildpacks:mainfrom
Draft
Add try-always pull policy and unit tests#2347kunalvirwal wants to merge 2 commits intobuildpacks:mainfrom
kunalvirwal wants to merge 2 commits intobuildpacks:mainfrom
Conversation
Signed-off-by: kunalvirwal <kunalvirwal@gmail.com>
Signed-off-by: Kunal Virwal <149074679+kunalvirwal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new pull-policy called
try-always.This policy first checks if an image is present in the remote registry and pulls it if available. If the image is not available on remote then it falls back to the local and looks for the image with the daemon.
The
try-alwayspull-policy follows a behaviour opposite toif-not-presentas it checks the remote first and then checks the local.Output
Before
alwaysand the image was not there on remote then pack would give an error.if-not-presentthen it would only pull if we didn't have it locally.After
try-alwayswe can have a custom image locally and still pull a fresh new image from the remote.Documentation
Related
Resolves #2201