feat: add support to use issue template from registry index for pack yank#2513
Open
burnerlee wants to merge 1 commit intobuildpacks:mainfrom
Open
feat: add support to use issue template from registry index for pack yank#2513burnerlee wants to merge 1 commit intobuildpacks:mainfrom
burnerlee wants to merge 1 commit intobuildpacks:mainfrom
Conversation
Author
|
@dmikusa @jjbustamante could you PTAL? |
| titleTemplateStr = title | ||
| bodyTemplateStr = body | ||
| } | ||
| // Silently fall back to hardcoded templates if loading fails |
Member
There was a problem hiding this comment.
I would at least throw a warning message in the log to inform that there was some issue parsing the template, and we are falling back to a hardcoded template
Member
|
Hi @burnerlee! Thanks for this PR, it looks good to me. Could you add some test coverage? especially for unhappy paths, I would like the users to easily provide logs or something if they have issues with the templates. |
Member
|
Also do not forget to signoff your commits for the DCO check to pass |
Author
|
Sure let me add some unit tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to read the issue template from registry-index while running
pack buildpack yank ....In case the template doesn't exist it falls back to the harcoded template. The hardcoded template has been updated to include
yank=truewhen.yankis true.Output
Before
Issue Body:
After
Issue Body:
Documentation
Related
resolves #2461