Code Test Android - Mati Lev

.gitignore

@@ -0,0 +1,13 @@
+*.iml
+.gradle
+/local.properties
+/.idea/caches
+/.idea/libraries
+/.idea/modules.xml
+/.idea/workspace.xml
+/.idea/navEditor.xml
+/.idea/assetWizardSettings.xml
+.DS_Store
+/build
+/captures
+.externalNativeBuild

README.md

@@ -16,12 +16,26 @@ Please clone the repository, complete the exercise, and submit a PR for us to re
 
 A) Describe the strategy used to consume the API endpoints and the data management.
 
+I used retrofit to consume the API and ROOM for save the responses locally. Also I used mappers to manage the data
+between cloud, database and domain.
+
 B) Explain which library was used for the routing and why. Would you use the same for a consumer facing app targeting thousands of users? Why?
 
+I used activities and Intents for routing, but I will use fragments if a more flexible UI that could support tablets is needed. Also,
+The navigation library from Jetpack is pretty interesting applications.
+Anyway, the three options are viable for apps with thousands of users.
+
 C) Have you used any strategy to optimize the performance of the list generated for the first feature?
 
+I used the paging library for improve the performance of the list rendered in the first feature.
+
 D) Would you like to add any further comments or observations?
 
+* Tested with mockk
+* With Clean Architecture in mind
+* MVVM for the presentation layer
+* Clean Code
+
 
 ## Overview:
 

app/.gitignore

@@ -0,0 +1 @@
+/build

app/build.gradle

@@ -0,0 +1,65 @@
+apply plugin: 'com.android.application'
+apply plugin: 'kotlin-android'
+apply plugin: 'kotlin-android-extensions'
+apply plugin: 'kotlin-kapt'
+
+android {
+    compileSdkVersion 28
+    defaultConfig {
+        applicationId "com.granitosdearena.matiaslev.cocktails"
+        minSdkVersion 21
+        targetSdkVersion 28
+        versionCode 1
+        versionName "1.0"
+        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
+    }
+    buildTypes {
+        release {
+            minifyEnabled false
+            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
+        }
+    }
+}
+
+dependencies {
+    implementation fileTree(dir: 'libs', include: ['*.jar'])
+
+    implementation 'io.reactivex.rxjava2:rxkotlin:2.3.0'
+
+    // All - Modules
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation 'org.koin:koin-core:2.0.0-rc-2'
+    implementation 'org.koin:koin-android-viewmodel:2.0.0-rc-2'
+
+    // All - Testing
+    testImplementation 'junit:junit:4.12'
+    testImplementation "io.mockk:mockk:1.9"
+
+    // Presentation
+    def lifecycle_version = "2.0.0"
+
+    implementation 'androidx.appcompat:appcompat:1.0.0-beta01'
+    implementation 'androidx.core:core-ktx:1.1.0-alpha05'
+    implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:$lifecycle_version"
+    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
+    implementation 'io.reactivex.rxjava2:rxandroid:2.1.0'
+    implementation 'androidx.recyclerview:recyclerview:1.0.0'
+    implementation 'com.github.bumptech.glide:glide:4.9.0'
+    kapt 'com.github.bumptech.glide:compiler:4.9.0'
+    implementation 'androidx.cardview:cardview:1.0.0'
+
+    // Data
+    def room_version = "2.1.0-alpha06"
+    def paging_version = "2.1.0"
+
+    implementation 'com.squareup.retrofit2:retrofit:2.5.0'
+    implementation 'com.squareup.retrofit2:converter-gson:2.5.0'
+    implementation 'com.squareup.retrofit2:adapter-rxjava2:2.4.0'
+
+    implementation "androidx.room:room-runtime:$room_version"
+    kapt "androidx.room:room-compiler:$room_version" // For Kotlin use kapt instead of annotationProcessor
+    implementation "androidx.room:room-rxjava2:$room_version"
+
+    implementation "androidx.paging:paging-runtime-ktx:$paging_version" // For Kotlin use paging-runtime-ktx
+    implementation "androidx.paging:paging-rxjava2-ktx:$paging_version" // For Kotlin use paging-rxjava2-ktx
+}

app/proguard-rules.pro

@@ -0,0 +1,21 @@
+# Add project specific ProGuard rules here.
+# You can control the set of applied configuration files using the
+# proguardFiles setting in build.gradle.
+#
+# For more details, see
+#   http://developer.android.com/guide/developing/tools/proguard.html
+
+# If your project uses WebView with JS, uncomment the following
+# and specify the fully qualified class name to the JavaScript interface
+# class:
+#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
+#   public *;
+#}
+
+# Uncomment this to preserve the line number information for
+# debugging stack traces.
+#-keepattributes SourceFile,LineNumberTable
+
+# If you keep the line number information, uncomment this to
+# hide the original source file name.
+#-renamesourcefileattribute SourceFile

app/src/main/AndroidManifest.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+          xmlns:tools="http://schemas.android.com/tools"
+          package="com.granitosdearena.matiaslev.cocktails">
+
+    <uses-permission android:name="android.permission.INTERNET"/>
+
+    <application
+            android:name=".CocktailsApp"
+            android:allowBackup="true"
+            android:icon="@mipmap/ic_launcher"
+            android:label="@string/app_name"
+            android:roundIcon="@mipmap/ic_launcher_round"
+            android:supportsRtl="true"
+            android:theme="@style/AppTheme"
+            tools:ignore="GoogleAppIndexingWarning">
+        <activity android:name=".presentation.activities.CocktailActivity">
+        </activity>
+        <activity android:name=".presentation.activities.CocktailPreviewActivity">
+            <intent-filter>
+                <action android:name="android.intent.action.MAIN"/>
+
+                <category android:name="android.intent.category.LAUNCHER"/>
+            </intent-filter>
+        </activity>
+    </application>
+
+</manifest>

app/src/main/java/com/granitosdearena/matiaslev/cocktails/CocktailsApp.kt

@@ -0,0 +1,18 @@
+package com.granitosdearena.matiaslev.cocktails
+
+import android.app.Application
+import com.granitosdearena.matiaslev.cocktails.presentation.appModule
+import org.koin.android.ext.koin.androidContext
+import org.koin.android.ext.koin.androidLogger
+import org.koin.core.context.startKoin
+
+class CocktailsApp: Application() {
+    override fun onCreate() {
+        super.onCreate()
+        startKoin {
+            androidLogger()
+            androidContext(this@CocktailsApp)
+            modules(appModule)
+        }
+    }
+}

app/src/main/java/com/granitosdearena/matiaslev/cocktails/data/CocktailsRepositoryImpl.kt

@@ -0,0 +1,65 @@
+package com.granitosdearena.matiaslev.cocktails.data
+
+import android.util.Log
+import androidx.paging.PagedList
+import androidx.paging.toObservable
+import com.granitosdearena.matiaslev.cocktails.data.cloud.CocktailsApi
+import com.granitosdearena.matiaslev.cocktails.data.database.AppDatabase
+import com.granitosdearena.matiaslev.cocktails.data.mappers.cocktail.CocktailCloudToDatabaseMapper
+import com.granitosdearena.matiaslev.cocktails.data.mappers.cocktail.ToCocktailFromDatabaseMapper
+import com.granitosdearena.matiaslev.cocktails.data.mappers.cocktailPreview.CocktailPreviewCloudToDatabaseMapper
+import com.granitosdearena.matiaslev.cocktails.data.mappers.cocktailPreview.ToCocktailPreviewFromDatabaseMapper
+import com.granitosdearena.matiaslev.cocktails.domain.Cocktail
+import com.granitosdearena.matiaslev.cocktails.domain.CocktailPreview
+import com.granitosdearena.matiaslev.cocktails.domain.CocktailsRepository
+import com.granitosdearena.matiaslev.cocktails.presentation.viewModels.CocktailPreviewViewModel
+import io.reactivex.Observable
+import io.reactivex.disposables.CompositeDisposable
+import io.reactivex.rxkotlin.subscribeBy
+import io.reactivex.schedulers.Schedulers
+
+class CocktailsRepositoryImpl(val cocktailsApi: CocktailsApi,
+                              val database: AppDatabase,
+                              val disposables: CompositeDisposable,
+                              val cocktailPreviewCloudToDatabaseMapper: CocktailPreviewCloudToDatabaseMapper,
+                              val cocktailCloudToDatabaseMapper: CocktailCloudToDatabaseMapper,
+                              val toCocktailPreviewFromDatabaseMapper: ToCocktailPreviewFromDatabaseMapper,
+                              val toCocktailFromDatabaseMapper: ToCocktailFromDatabaseMapper): CocktailsRepository {
+
+    override fun syncCockailsPreview(): Observable<PagedList<CocktailPreview>> {
+        val disposable = cocktailsApi.getCockailsPreview()
+            .subscribeOn(Schedulers.io())
+            .doOnError { Log.d(CocktailPreviewViewModel::class.java.canonicalName, it.message) }
+            .map { database.cocktailPreviewDao().insertAll(cocktailPreviewCloudToDatabaseMapper.transform(it)) }
+            .subscribeBy(
+                onError =  { it.printStackTrace() },
+                onSuccess = {  }
+            )
+        disposables.add(disposable)
+
+        return database.cocktailPreviewDao().getAll()
+            .map { toCocktailPreviewFromDatabaseMapper.transform(it) }
+            .toObservable(10)
+    }
+
+    override fun searchCocktailsPreviewByName(name: String): Observable<PagedList<CocktailPreview>> =
+        database.cocktailPreviewDao().searchCocktailPreviewByName("%$name%")
+            .map { toCocktailPreviewFromDatabaseMapper.transform(it) }
+            .toObservable(10)
+
+    override fun getCocktail(drinkId: String): Observable<Cocktail> {
+        val disposable = cocktailsApi.getCocktail(drinkId)
+            .subscribeOn(Schedulers.io())
+            .doOnError { Log.d(CocktailPreviewViewModel::class.java.canonicalName, it.message) }
+            .filter { it.drinks.isNotEmpty() }
+            .map { database.cocktailDao().insert(cocktailCloudToDatabaseMapper.transform(it.drinks.first())) }
+            .subscribeBy(
+                onError =  { it.printStackTrace() },
+                onSuccess = {  }
+            )
+        disposables.add(disposable)
+
+        return database.cocktailDao().searchCocktailById(drinkId.toInt())
+            .map { toCocktailFromDatabaseMapper.transform(it) }
+    }
+}

app/src/main/java/com/granitosdearena/matiaslev/cocktails/data/cloud/CocktailsApi.kt

@@ -0,0 +1,17 @@
+package com.granitosdearena.matiaslev.cocktails.data.cloud
+
+import com.granitosdearena.matiaslev.cocktails.data.cloud.model.CocktailCloudList
+import com.granitosdearena.matiaslev.cocktails.data.cloud.model.CocktailPreviewCloudList
+import io.reactivex.Single
+import retrofit2.http.GET
+import retrofit2.http.Query
+
+interface CocktailsApi {
+
+    @GET("filter.php?g=Cocktail_glass")
+    fun getCockailsPreview(): Single<CocktailPreviewCloudList>
+
+    @GET("lookup.php?")
+    fun getCocktail(@Query("i") id: String): Single<CocktailCloudList>
+
+}