Skip to content

Code challenge#7

Open
jevvilla wants to merge 46 commits intobuoydevelopment:masterfrom
jevvilla:code-challenge
Open

Code challenge#7
jevvilla wants to merge 46 commits intobuoydevelopment:masterfrom
jevvilla:code-challenge

Conversation

@jevvilla
Copy link

@jevvilla jevvilla commented Oct 3, 2019 •
edited
Loading

Checklist:

  • README.md file updated accordingly.
  • Tests added to cover partially some of the features.
  • All tests passed locally.

Screenshots:

Fetching cocktails loading state:

Simulator Screen Shot - iPhone X - 2019-10-03 at 17 11 06

Successfully cocktails loaded and rendered:

Simulator Screen Shot - iPhone X - 2019-10-03 at 17 11 16

No results message state:

Simulator Screen Shot - iPhone X - 2019-10-03 at 17 12 06

Successful search:

Simulator Screen Shot - iPhone X - 2019-10-03 at 17 11 47

Details screen:

Simulator Screen Shot - iPhone X - 2019-10-03 at 17 12 30

Juan Esteban Villa and others added 30 commits October 3, 2019 07:02
initial commit
963d058
@jevvilla
adding some eslint and prettier rules for better code quality, yarn.l…
ba6c94a 
…ock file was removed
@jevvilla
eslint, prettier packages and plugins were installed
65da484
@jevvilla
react navigation integrated for Android and iOS platforms
2e87670
@jevvilla
configuring metro to support .jsx files
0976aab
@jevvilla
colors file created
ec1ad79
@jevvilla
App.js was deleted and replaced by App.jsx in src folder
c4ad552
@jevvilla
strings, styles and routes files were created inside common folder to…
cd8e0ef 
… be shared all across the project
@jevvilla
CocktailCard component was created to display info of each cocktail
8691eb2
@jevvilla
CocktailsCardList created to build a list based off all data coming f…
febbff7 
…rom API
@jevvilla
Overview screen is the initial screen of the app where all cards will…
ed74345 
… be displayed
@jevvilla
stack navigator created inside navigation folder
282ef55
@jevvilla
Router imported in App.jsx to display Overview as initial screen
8fd1231
@jevvilla
common PropTypes added
f251fd2
@jevvilla
OVERVIEW_HEADER_TITLE new string added to strings file
f2c703d
@jevvilla
header global styles added to styles.js common file
df03851
@jevvilla
onPress function implemented in CocktailCard component to be able to …
3c73cc4 
…navigate to Details
@jevvilla
Details screen created and added to stack navigator, header style was…
5647d6c 
… applied
@jevvilla
navigationOptions implemented in Overview screen, some PropTypes added
8e78881
@jevvilla
CocktailsCardList component updated to include PropTypes and navigate…
b8e7357 
… function
@jevvilla
icons packages implemented to the app
b6551a9
@jevvilla
lodash package added to operate arrays and objects
81a24b5
@jevvilla
whiteOpacity new global color added
425b4e4
@jevvilla
search field UI was implemented in the header of Overview screen
9d27a91
@jevvilla
search functionality added based off overview screen component state
5c026d7
@jevvilla
redux, redux thunk and react redux packages added to the project
1f888ef
@jevvilla
reducers, actions, action types and provider implemented
c55f0b6
@jevvilla
connecting Overview screen to redux store
c261e0f
@jevvilla
requesting data using fetch and redux thunk
a3e638a
@jevvilla
header title is beign redered in details using params
03b0a26
jevvilla added 16 commits October 3, 2019 09:33
@jevvilla
ingredients are displayed in the CocktailCard component
324d148
@jevvilla
getIngredientsAndMeasurements function was added as a helper to get m…
8b2b8bb 
…easures and ingredientes combined and ready to render in the screen
@jevvilla
CocktailDetailsCard component created to hold details of the card
9cf0b62
@jevvilla
uri, instructions, and measures are being passed to Details as params…
dd96b31 
… to be rendered
@jevvilla
Details screen component pass all needed data to CocktailDetailsCard …
aa99a29 
…component
@jevvilla
propTypes were modified
321fa8b
@jevvilla
empty search state message added
36c215f
@jevvilla
jest configuration for testing
37f26de
@jevvilla
jest test added for App.jsx file, and setup.js file added to hold all…
9a99f69 
… mocked modules
@jevvilla
undefined item bug detected in tools functions during unit testing an…
f1dee61 
…d resolved
@jevvilla
__mocks__ added and common folder tests added
7f88ebb
@jevvilla
CocktailCard covered with jest test
e21c825
@jevvilla
Details screen covered with jest test
2b8b1eb
@jevvilla
getItemLayout was implemented as FlatList performance improvement
5674eae
@jevvilla
QUESTIONS_ANSWERED file was added, this file holds all responsed to e…
55072ec 
…ach of the questions
@jevvilla
README updated, instructions for setup/config and running the app
12c0676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jevvilla

Comments