Review #9
Open
Review #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing UsersNetworkDataSource using Ktor as http client. Json parsing is done by Kotlinx serialization. Parsing tests were added in UsersApiTest.
This is necessary to not be warned about using @Incubating features.
UsersRepository is implemented by NetworkUsersRepository, which is using only one DataSource - UsersNetworkDataSource. Test were added in NetworkUsersRepositoryTest.
UI State is represented by class UserListUiState. Tests were implemented in UserListViewModelTest.
Added Koin modules for data:users:network, data:users:repository and ui:userlist. In :app module DI was configured using cokoin and WithDependencyInjection Composable function.
As this module includes :data:users:model via api() I think it's better to call it :core than :repository.
…dule I plan to use FakeUsersRepository and TestUsers in :ui:userdetails - extracting to separate module will help me reuse it there.
Next version - contains error handling, pagination and Compose Multiplatform
Update dependency com.alialbaali.kamel:kamel-image to v0.4.1
Update dependency gradle to v7.6
AlexKrupa
approved these changes
Dec 7, 2022
app/android/src/androidTest/kotlin/dev/burnoo/demo/listapp/AndroidAppTest.kt
Show resolved
Hide resolved
.../compose-utils/src/commonMain/kotlin/dev/burnoo/demo/listapp/core/compose/utils/di/Module.kt
Show resolved
Hide resolved
...est/src/commonMain/kotlin/dev/burnoo/demo/listapp/data/users/network/test/GetUserResponse.kt
Show resolved
Hide resolved
...ers/network/src/commonMain/kotlin/dev/burnoo/demo/listapp/data/users/network/api/UsersApi.kt
Show resolved
Hide resolved
| package dev.burnoo.demo.listapp.data.users.network.model | ||
|
|
||
| enum class NetworkError { | ||
| Client, Server, Device |
There was a problem hiding this comment.
What's the difference between client and device here?
Owner
Author
There was a problem hiding this comment.
Client -> 4xx
Device -> No Internet, etc.
I will think about better naming
There was a problem hiding this comment.
Device -> Network maybe? I'd expect IOException or `SocketTimeoutException or similar, don't know about others.
...c/commonMain/kotlin/dev/burnoo/demo/listapp/ui/userdetails/composables/UserDetailsContent.kt
Show resolved
Hide resolved
ui/userlist/src/commonMain/kotlin/dev/burnoo/demo/listapp/ui/userlist/composables/UserList.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for CR, comments are welcome 🕵️