Conversation
- Complete development session documentation with technical decisions - Add lessons learned about ChurchTools API patterns and data structures - Document ID-to-name mapping strategy for future reference Co-authored-by: Ona <no-reply@ona.com>
Change from 'churchdb' + 'administer groups' to 'churchgroup' + 'view' to make the module accessible to more users while maintaining security. The previous permission was too restrictive - users only need to view groups to see automatic group information, not administer them. Co-authored-by: Ona <no-reply@ona.com>
- Remove trailing whitespace - Add missing newline at end of file Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #24
This PR adds the missing documentation and permission adjustments that were created after the initial automatic groups grouptype fix was merged.
Changes
Documentation
Permission Fix
Commits
These commits were created after PR #24 was merged and contain important documentation and permission improvements.