Fix retrying for ignored error codes#249
Open
SharpKoi wants to merge 1 commit intobybit-exchange:masterfrom
Open
Fix retrying for ignored error codes#249SharpKoi wants to merge 1 commit intobybit-exchange:masterfrom
SharpKoi wants to merge 1 commit intobybit-exchange:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ret_codeis not zero and not ignored, the program will never return the JSON response, either raise an error or retry instead. Note that I did not write tests for scenarios like retrying, ignoring, or raising errors since I believe refactoring the_submit_requestfunction is necessary. Therefore, I've focus merely on resolving the issue I mentioned.