_V5TradeWebSocketManager: Send error messages on callback_function#287
_V5TradeWebSocketManager: Send error messages on callback_function#287nietsuu wants to merge 1 commit intobybit-exchange:masterfrom
Conversation
|
I think the current way of handling errors won't do (just logging it). Because sometimes you need to catch the errors and currently there is no way of doing that. If this PR is not plausible. Maybe we can add another callback like |
kolya5544
left a comment
There was a problem hiding this comment.
Code changes look good to me, however backwards compatability implications should be considered for people updating from older pybit versions
|
I think it's safe to assume that everyone that uses this don't have a code that results in error. So if they update, it really won't break anything. And if they do have an error, they will still have to fix it anyways. |
I am using the
WebSocketTradingand noticed that it doesn't send the error messages on thecallback. It just logs the error on_V5TradeWebSocketManager._process_error_message.I'm thinking it would be better to just send the error messages on the
callbackinstead of logging it.