Added 4k videos + error handling for invalid video source#145
Open
jonathonwpowell wants to merge 3 commits intocDima:masterfrom
Open
Added 4k videos + error handling for invalid video source#145jonathonwpowell wants to merge 3 commits intocDima:masterfrom
jonathonwpowell wants to merge 3 commits intocDima:masterfrom
Conversation
|
Some dirty hacks to get 4k videos work without compiling (this is my first write on github, so keep cool):
|
|
@joerchnet I'm understanding what you're doing for the most part but you're just renaming the files and deleting the old SD ones so that you can replace them with the renamed 4K ones correct? I'm trying to get the ISS aerials to work and I seem to be doing something wrong is all. |
|
@Simsz Try the following: |
|
What's missing/needs to be done to get this PR merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the ability to use the 4K videos through a button on the new Video Source tab. It links to a json document I am hosting, as the new JSON is in the incorrect format and this would be the easiest way for now and I couldn't think of a more elegant way. If you have any ideas for doing it better, let me know