Skip to content

Comments

[WIP] Improve repository registration process#155

Closed
Copilot wants to merge 1 commit intofeature/improve-repo-registration-2from
copilot/sub-pr-154
Closed

[WIP] Improve repository registration process#155
Copilot wants to merge 1 commit intofeature/improve-repo-registration-2from
copilot/sub-pr-154

Conversation

Copy link
Contributor

Copilot AI commented Dec 30, 2025

Thanks for the feedback on #154. I've created this new PR, which merges into #154, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #154
Triggering comment (#154 (comment)):

@copilot

Read attached ADR: docs/adr/0006-ux-secrets-mgt-on-registration.md

Given that read_secret_version returns data of this form:
"""
{
"request_id":"a14f4fce-cd7e-2794-cbe5-cec07294119f",
"lease_id":"",
"renewable":false,
"lease_duration":0,
"data":{
"data":{
"accessKey":"f1",
"bucket":"foo",
"is_aws":true,
"secretKey":"f2"
},
"metadata":{
"created_time":"2025-1230T13:42:46.443541392Z",
"custom_metadata":"None",
"deletion_time":"",
"destroyed":false,
"version":1
}
},
"wrap_info":"None",
"warnings":"None",
"auth":"None",
"mount_type":"kv"
}
"""

Change behavior of update.

  • For each bucket, [dataBucket, artifactBucket]:
    • Change the behavior of get_registration. Return dataBucketCreatedTime, artifactBucketCreatedTime, set from data.metadata.created_time
    • If it exist, display a notice "This bucket information was saved on {xxxxBucketCreatedTime}. Click here to re-enter."
      • If the user clicks, reveal the bucket form.
  • If the bucket information doesn't exist, display the form

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants