Skip to content

Comments

Request clarification on secretKey naming inconsistency fix approach#159

Draft
Copilot wants to merge 41 commits intodevelopmentfrom
copilot/sub-pr-154-another-one
Draft

Request clarification on secretKey naming inconsistency fix approach#159
Copilot wants to merge 41 commits intodevelopmentfrom
copilot/sub-pr-154-another-one

Conversation

Copy link
Contributor

Copilot AI commented Jan 2, 2026

Review feedback identified inconsistent secretKey naming in ExternalSecrets: one uses privateKey, another uses token. The suggestion is to adopt Kubernetes naming conventions (e.g., github-token, private-key).

Current state:

# First ExternalSecret (line 34)
- secretKey: privateKey

# Second ExternalSecret (line 68)  
- secretKey: token

Blocked on decision:
Cannot programmatically create GitHub issues. Need direction on whether to:

  • Fix directly in this PR (breaking change for existing deployments)
  • Document for manual issue creation
  • Alternative approach

No code changes made pending clarification.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] WIP address feedback on repo registration improvements Request clarification on secretKey naming inconsistency fix approach Jan 2, 2026
Copilot AI requested a review from bwalsh January 2, 2026 19:02
Base automatically changed from feature/improve-repo-registration-2 to development January 2, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants