Skip to content

Comments

Document gitapp-callback secret misconfiguration bug#160

Closed
Copilot wants to merge 41 commits intodevelopmentfrom
copilot/sub-pr-154-yet-again
Closed

Document gitapp-callback secret misconfiguration bug#160
Copilot wants to merge 41 commits intodevelopmentfrom
copilot/sub-pr-154-yet-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 2, 2026

A code review identified that gitapp-callback deployment's init container checks for the wrong secret name (references githubStatusProxy.privateKeySecret.name instead of its own GitHub App private key secret).

Changes

  • Provided detailed bug report for manual issue creation
  • Unable to create GitHub issue programmatically due to missing API capabilities
  • Documented affected lines (37, 151 in 32-gitapp-callback.yaml)
  • Suggested fix: add privateKeySecret config under gitappCallback or default to githubApp.privateKeySecretName

Current Bug

# Line 37: Wrong secret reference
echo "Waiting for secret {{ .Values.githubStatusProxy.privateKeySecret.name }} to be available..."

# Line 82: Uses githubApp config
- name: GITHUB_APP_ID
  value: {{ .Values.githubApp.appId | quote }}

# Line 151: Wrong secret reference
secretName: {{ .Values.githubStatusProxy.privateKeySecret.name }}

The init container will wait indefinitely or fail to detect missing secrets since it's checking githubStatusProxy's secret instead of gitapp-callback's own GitHub App credentials.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Address feedback on repo registration feature improvements Document gitapp-callback secret misconfiguration bug Jan 2, 2026
Copilot AI requested a review from bwalsh January 2, 2026 19:03
Base automatically changed from feature/improve-repo-registration-2 to development January 2, 2026 19:54
@bwalsh
Copy link
Contributor

bwalsh commented Jan 2, 2026

done. documented shared secret

@bwalsh bwalsh closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants