Skip to content

Comments

Respond to feedback on hardcoded Makefile values#161

Closed
Copilot wants to merge 41 commits intodevelopmentfrom
copilot/sub-pr-154-one-more-time
Closed

Respond to feedback on hardcoded Makefile values#161
Copilot wants to merge 41 commits intodevelopmentfrom
copilot/sub-pr-154-one-more-time

Conversation

Copy link
Contributor

Copilot AI commented Jan 2, 2026

Reviewer flagged hardcoded githubRepoUrl and githubUserName values in Makefile deployment target.

Responded to the request to create an issue explaining that:

  • Cannot create GitHub issues directly due to environment constraints
  • Offered to either fix the issue inline or provide documentation for manual issue creation

Proposed fix would align with existing pattern:

# Current (hardcoded)
--set-string gitappCallback.githubRepoUrl=https://github.com/calypr/registrations-test \
--set-string gitappCallback.githubUserName=bwalsh \

# Proposed (environment variables)
--set-string gitappCallback.githubRepoUrl="${GITAPP_CALLBACK_REPO_URL}" \
--set-string gitappCallback.githubUserName="${GITAPP_CALLBACK_USER_NAME}" \

Awaiting direction on preferred approach.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update implementation based on feedback for repo registration Respond to feedback on hardcoded Makefile values Jan 2, 2026
Copilot AI requested a review from bwalsh January 2, 2026 19:05
Base automatically changed from feature/improve-repo-registration-2 to development January 2, 2026 19:54
@bwalsh
Copy link
Contributor

bwalsh commented Jan 2, 2026

done

@bwalsh bwalsh closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants