Open
Conversation
Member
javiertoledo
left a comment
javiertoledo
left a comment
There was a problem hiding this comment.
Wow, this looks like a huge lot of added complexity just to have a form in the page, isn't it?
Member
|
Also, the current page is being directly served from GitHub pages. The easiest way to make this version work with Github Pages would be to compile the static page to the |
Co-Authored-By: Javier Toledo <javier@theagilemonkeys.com>
Co-Authored-By: Javier Toledo <javier@theagilemonkeys.com>
Contributor
Author
|
It has more than just a form, the databases are reactive, and there is a control panel to manage new signatures. It is also a PWA installable with the idea that in the future the application grows, and we can put blogs, or mechanisms for job offers. |
Member
|
I saw that you deployed it to a new domain in firebase, so no need to keep serving it from GH Pages, I guess 😜 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Con esta nueva versión solo hace falta rellenar un formulario para firmar el manifiesto. Ademas el resultado sigue siendo una pagina estática (aunque ahora sea dinámica), así que se puede alojar donde estaba la anterior.