-
Notifications
You must be signed in to change notification settings - Fork 71
feat(26.04): add golang 1.25 #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhijie-yang
wants to merge
10
commits into
canonical:ubuntu-26.04
Choose a base branch
from
zhijie-yang:golang-26.04
base: ubuntu-26.04
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c50c30c
feat(25.04): add golang-1.24
zhijie-yang fccd8b3
feat(26.04): apply changes for golang-1.25
zhijie-yang 4673aab
chore(26.04): apply changes from code review
zhijie-yang bbd0fbe
feat(26.04): add cgo-support
zhijie-yang dd537a7
Merge branch 'ubuntu-26.04' into golang-26.04
zhijie-yang e57b2a7
Merge branch 'ubuntu-26.04' into golang-26.04
zhijie-yang fab59b3
Merge branch 'ubuntu-26.04' into golang-26.04
zhijie-yang 535b1c1
Merge branch 'ubuntu-26.04' into golang-26.04
zhijie-yang 0da5b8e
Merge branch 'ubuntu-26.04' into golang-26.04
zhijie-yang 47a86e3
Merge branch 'ubuntu-26.04' into golang-26.04
lczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| package: golang-1.25-go | ||
|
|
||
| essential: | ||
| - golang-1.25-go_copyright | ||
|
|
||
| slices: | ||
| # Note: The minimal slice provides a working Go installation | ||
| # that can be used to build and run simple Go programs, | ||
| # such as a "Hello World" program. | ||
| # See tests/spread/integration/golang-1.25-go/test_minimal.sh | ||
| # for more details. | ||
| minimal: | ||
| essential: | ||
| - base-files_tmp | ||
| - golang-1.25-go_build-tools | ||
| - golang-1.25-go_headers | ||
| - golang-1.25-go_symlinks | ||
| - golang-1.25-src_src-with-tests | ||
| contents: | ||
| /usr/lib/go-1.25/bin/go: | ||
| /usr/lib/go-1.25/bin/gofmt: | ||
|
|
||
| # Note: The core slices provides the source code within the golang-1.25-go | ||
| # package in additional to the minimal slice. | ||
| core: | ||
| essential: | ||
| - golang-1.25-go_cmd-src | ||
| - golang-1.25-go_go-env | ||
| - golang-1.25-go_internal-src | ||
| - golang-1.25-go_minimal | ||
| - golang-1.25-go_runtime-src | ||
| - golang-1.25-go_time-src | ||
|
|
||
| # Note: The build-tools provides the essential Go tools for building | ||
| # a minimal Go program, i.e., a single Hello World program. | ||
| build-tools: | ||
| contents: | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/asm: | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/compile: | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/link: | ||
| # vet is used for go test | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/vet: | ||
|
|
||
| cgo-tools: | ||
| essential: | ||
| - gcc_gcc | ||
| - libc6-dev_core | ||
| - libc6-dev_libresolv | ||
| - libc6-dev_runtime | ||
| contents: | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/cgo: | ||
|
|
||
| cmd-src: | ||
| contents: | ||
| /usr/share/go-1.25/src/cmd/cgo/zdefaultcc.go: | ||
| /usr/share/go-1.25/src/cmd/go/internal/cfg/zdefaultcc.go: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/zbootstrap.go: | ||
|
|
||
| go-env: | ||
| contents: | ||
| /usr/lib/go-1.25/go.env: | ||
|
|
||
| headers: | ||
| contents: | ||
| /usr/share/go-1.25/pkg/include/*.h: | ||
|
|
||
| internal-src: | ||
| contents: | ||
| /usr/share/go-1.25/src/internal/buildcfg/zbootstrap.go: | ||
|
|
||
| profiling-tools: | ||
| contents: | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/preprofile: | ||
|
|
||
| runtime-src: | ||
| contents: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/zversion.go: | ||
|
|
||
| symlinks: | ||
| contents: | ||
| /usr/lib/go-1.25/api: # Symlink to ../share/go-1.25/api | ||
| /usr/lib/go-1.25/lib: # Symlink to ../share/go-1.25/lib | ||
| /usr/lib/go-1.25/misc: # Symlink to ../share/go-1.25/misc | ||
| /usr/lib/go-1.25/pkg/include: # Symlink to ../share/go-1.25/pkg/include | ||
| /usr/lib/go-1.25/src: # Symlink to ../share/go-1.25/src | ||
| /usr/lib/go-1.25/test: # Symlink to ../share/go-1.25/test | ||
|
|
||
| testing-tools: | ||
| contents: | ||
| /usr/lib/go-1.25/pkg/tool/linux_*/cover: | ||
|
|
||
| time-src: | ||
| contents: | ||
| /usr/share/go-1.25/src/time/tzdata/zzipdata.go: | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/golang-1.25-go/copyright: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,231 @@ | ||
| package: golang-1.25-src | ||
|
|
||
| essential: | ||
| - golang-1.25-src_copyright | ||
|
|
||
| slices: | ||
| # Note: This slice contains the source code of Go 1.25 as well as the tests. | ||
| # Due to Go's project layout convention, we cannot split the source code | ||
| # easily without Chisel's support for negative wildcards. | ||
| # To exclude the tests and test data, a command should be run after cutting | ||
| # this slice: | ||
| # find . -depth \( \ | ||
| # \( -path '*test*' \ | ||
| # ! -path '*src/testing*' \ | ||
| # ! -path '*src/internal/test*' \ | ||
| # ! -path '*src/internal/synctest' \ | ||
| # ! -path '*synctest.go' \ | ||
zhijie-yang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # ! -path '*synctest_o*' \) -o \ | ||
| # \( -path '*/testing/*' -name '*_test.go' \) \ | ||
| # \) -exec rm -rf {} + | ||
| src-with-tests: | ||
| essential: | ||
| - golang-1.25-src_api | ||
| - golang-1.25-src_libs | ||
| contents: | ||
| # Note: Some paths are explicitly listed to avoid conflicts with | ||
| # the paths defined in golang-1.25-go. | ||
| # src/cmd/** conflicts with | ||
| # src/cmd/cgo/zdefaultcc.go | ||
| # src/cmd/go/internal/cfg/zdefaultcc.go | ||
| # src/cmd/internal/objabi/zbootstrap.go | ||
| # src/internal/** conflicts with | ||
| # src/internal/buildcfg/zbootstrap.go | ||
| # src/internal/runtime/sys/zversion.go | ||
| # src/time/** conflicts with | ||
| # src/time/tzdata/zzipdata.go | ||
| /usr/share/go-1.25/misc/**: | ||
| /usr/share/go-1.25/src/Make.dist: | ||
| /usr/share/go-1.25/src/a*/**: | ||
| /usr/share/go-1.25/src/b*/**: | ||
| /usr/share/go-1.25/src/cmd/a*/**: | ||
| /usr/share/go-1.25/src/cmd/b*/**: | ||
| /usr/share/go-1.25/src/cmd/cgo/a*.go: | ||
| /usr/share/go-1.25/src/cmd/cgo/doc.go: | ||
| /usr/share/go-1.25/src/cmd/cgo/g*.go: | ||
| /usr/share/go-1.25/src/cmd/cgo/internal/**: | ||
| /usr/share/go-1.25/src/cmd/cgo/main.go: | ||
| /usr/share/go-1.25/src/cmd/cgo/out.go: | ||
| /usr/share/go-1.25/src/cmd/cgo/util.go: | ||
| /usr/share/go-1.25/src/cmd/co*/**: | ||
| /usr/share/go-1.25/src/cmd/d*/**: | ||
| /usr/share/go-1.25/src/cmd/f*/**: | ||
| /usr/share/go-1.25/src/cmd/go.mod: | ||
| /usr/share/go-1.25/src/cmd/go.sum: | ||
| /usr/share/go-1.25/src/cmd/go/*.go: | ||
| /usr/share/go-1.25/src/cmd/go/internal/a*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/b*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/ca*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/cfg/bench_test.go: | ||
| /usr/share/go-1.25/src/cmd/go/internal/cfg/cfg.go: | ||
| /usr/share/go-1.25/src/cmd/go/internal/cl*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/cm*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/d*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/e*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/f*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/g*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/h*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/i*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/l*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/m*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/r*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/s*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/t*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/v*/**: | ||
| /usr/share/go-1.25/src/cmd/go/internal/w*/**: | ||
| /usr/share/go-1.25/src/cmd/go/t*/**: | ||
| /usr/share/go-1.25/src/cmd/gof*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/a*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/b*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/c*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/d*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/e*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/g*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/h*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/m*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/obj/**: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/a*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/f*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/h*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/l*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/p*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/r*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/s*: | ||
| /usr/share/go-1.25/src/cmd/internal/objabi/u*: | ||
| /usr/share/go-1.25/src/cmd/internal/objfile/*.go: | ||
| /usr/share/go-1.25/src/cmd/internal/os*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/p*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/q*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/r*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/s*/**: | ||
| /usr/share/go-1.25/src/cmd/internal/t*/**: | ||
| /usr/share/go-1.25/src/cmd/l*/**: | ||
| /usr/share/go-1.25/src/cmd/n*/**: | ||
| /usr/share/go-1.25/src/cmd/o*/**: | ||
| /usr/share/go-1.25/src/cmd/p*/**: | ||
| /usr/share/go-1.25/src/cmd/r*/**: | ||
| /usr/share/go-1.25/src/cmd/t*/**: | ||
| /usr/share/go-1.25/src/cmd/v*/**: | ||
| /usr/share/go-1.25/src/cmp/**: | ||
| /usr/share/go-1.25/src/co*/**: | ||
| /usr/share/go-1.25/src/crypto/**: | ||
| /usr/share/go-1.25/src/d*/**: | ||
| /usr/share/go-1.25/src/e*/**: | ||
| /usr/share/go-1.25/src/f*/**: | ||
| /usr/share/go-1.25/src/go.mod: | ||
| /usr/share/go-1.25/src/go.sum: | ||
| /usr/share/go-1.25/src/go/**: | ||
| /usr/share/go-1.25/src/h*/**: | ||
| /usr/share/go-1.25/src/im*/**: | ||
| /usr/share/go-1.25/src/ind*/**: | ||
| /usr/share/go-1.25/src/internal/a*/**: | ||
| /usr/share/go-1.25/src/internal/bi*/**: | ||
| /usr/share/go-1.25/src/internal/buildcfg/c*: | ||
| /usr/share/go-1.25/src/internal/buildcfg/e*: | ||
| /usr/share/go-1.25/src/internal/by*/**: | ||
| /usr/share/go-1.25/src/internal/c*/**: | ||
| /usr/share/go-1.25/src/internal/d*/**: | ||
| /usr/share/go-1.25/src/internal/e*/**: | ||
| /usr/share/go-1.25/src/internal/f*/**: | ||
| /usr/share/go-1.25/src/internal/g*/**: | ||
| /usr/share/go-1.25/src/internal/i*/**: | ||
| /usr/share/go-1.25/src/internal/l*/**: | ||
| /usr/share/go-1.25/src/internal/m*/**: | ||
| /usr/share/go-1.25/src/internal/n*/**: | ||
| /usr/share/go-1.25/src/internal/o*/**: | ||
| /usr/share/go-1.25/src/internal/p*/**: | ||
| /usr/share/go-1.25/src/internal/ra*/**: | ||
| /usr/share/go-1.25/src/internal/re*/**: | ||
| /usr/share/go-1.25/src/internal/ro*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/a*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/c*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/e*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/g*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/m*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/st*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/c*: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/d*: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/e*: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/i*: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/n*: | ||
| /usr/share/go-1.25/src/internal/runtime/sys/s*: | ||
| /usr/share/go-1.25/src/internal/runtime/sysc*/**: | ||
| /usr/share/go-1.25/src/internal/runtime/w*/**: | ||
| /usr/share/go-1.25/src/internal/s*/**: | ||
| /usr/share/go-1.25/src/internal/t*/**: | ||
| /usr/share/go-1.25/src/internal/u*/**: | ||
| /usr/share/go-1.25/src/internal/x*/**: | ||
| /usr/share/go-1.25/src/internal/z*/**: | ||
| /usr/share/go-1.25/src/io*/**: | ||
| /usr/share/go-1.25/src/it*/**: | ||
| /usr/share/go-1.25/src/l*/**: | ||
| /usr/share/go-1.25/src/m*/**: | ||
| /usr/share/go-1.25/src/n*/**: | ||
| /usr/share/go-1.25/src/o*/**: | ||
| /usr/share/go-1.25/src/p*/**: | ||
| /usr/share/go-1.25/src/re*/**: | ||
| /usr/share/go-1.25/src/runtime/**.S: | ||
| /usr/share/go-1.25/src/runtime/**.c: | ||
| /usr/share/go-1.25/src/runtime/**.h: | ||
| /usr/share/go-1.25/src/runtime/**.s: | ||
| /usr/share/go-1.25/src/runtime/*.go: | ||
| /usr/share/go-1.25/src/runtime/*.py: | ||
| /usr/share/go-1.25/src/runtime/Makefile: | ||
| /usr/share/go-1.25/src/runtime/a*/**: | ||
| /usr/share/go-1.25/src/runtime/c*/**: | ||
| /usr/share/go-1.25/src/runtime/d*/**: | ||
| # /usr/share/go-1.25/src/runtime/internal/st*/**: | ||
| # /usr/share/go-1.25/src/runtime/internal/w*/**: | ||
| /usr/share/go-1.25/src/runtime/m*/**: | ||
| /usr/share/go-1.25/src/runtime/p*/**: | ||
| /usr/share/go-1.25/src/runtime/r*/**: | ||
| /usr/share/go-1.25/src/runtime/t*/**: | ||
| /usr/share/go-1.25/src/s*/**: | ||
| /usr/share/go-1.25/src/te*/**: | ||
| /usr/share/go-1.25/src/time/*.go: | ||
| /usr/share/go-1.25/src/time/te*/**: | ||
| /usr/share/go-1.25/src/time/tzdata/tzdata.go: | ||
| /usr/share/go-1.25/src/u*/**: | ||
| /usr/share/go-1.25/src/v*/**: | ||
| /usr/share/go-1.25/src/w*/**: | ||
| /usr/share/go-1.25/test/**: | ||
|
|
||
| api: | ||
| contents: | ||
| /usr/share/go-1.25/api/*.txt: | ||
|
|
||
| bash-scripts: | ||
| essential: | ||
| - bash_bins | ||
| - binutils_linker | ||
| # TODO: Include binutils-${ARCH_TRIPLET}_loader as well. | ||
| - coreutils_bins | ||
| - grep_bins | ||
| contents: | ||
| /usr/share/go-1.25/src/all.bash: | ||
| /usr/share/go-1.25/src/bootstrap.bash: | ||
| /usr/share/go-1.25/src/buildall.bash: | ||
| /usr/share/go-1.25/src/clean.bash: | ||
| /usr/share/go-1.25/src/cmp.bash: | ||
| /usr/share/go-1.25/src/make.bash: | ||
| /usr/share/go-1.25/src/race.bash: | ||
| /usr/share/go-1.25/src/run.bash: | ||
|
|
||
| libs: | ||
| essential: | ||
| - bash_bins | ||
| - coreutils_bins | ||
| - make_bins | ||
| contents: | ||
| /usr/share/go-1.25/lib/fips140/Makefile: | ||
| /usr/share/go-1.25/lib/fips140/fips140.sum: | ||
| /usr/share/go-1.25/lib/fips140/inprocess.txt: | ||
| /usr/share/go-1.25/lib/fips140/v1.0.0.zip: | ||
| /usr/share/go-1.25/lib/time/mkzip.go: | ||
| /usr/share/go-1.25/lib/time/update.bash: | ||
| /usr/share/go-1.25/lib/time/zoneinfo.zip: | ||
| /usr/share/go-1.25/lib/wasm/*: | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/golang-1.25-src/copyright: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package: golang-1.25 | ||
|
|
||
| essential: | ||
| - golang-1.25_copyright | ||
|
|
||
| slices: | ||
| core: | ||
| essential: | ||
| # Note: Package golang-1.25-go is not available on i386. | ||
| - golang-1.25-go_core | ||
| - golang-1.25-src_src-with-tests | ||
|
|
||
zhijie-yang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cgo-support: | ||
| essential: | ||
| - golang-1.25-go_cgo-tools | ||
| - golang-1.25_core | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/golang-1.25/copyright: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package: golang-go | ||
|
|
||
| essential: | ||
| - golang-go_copyright | ||
|
|
||
| slices: | ||
| core: | ||
| essential: | ||
| - golang-1.25-go_core | ||
| contents: | ||
| /usr/bin/go: # Symlink to ../lib/go-1.25/bin/go | ||
| /usr/bin/gofmt: # Symlink to ../lib/go-1.25/bin/gofmt | ||
| /usr/lib/go: # Symlink to ../share/go-1.25 | ||
|
|
||
| cgo-tools: | ||
| essential: | ||
| - golang-1.25-go_cgo-tools | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/golang-go/copyright: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package: golang-src | ||
|
|
||
| essential: | ||
| - golang-src_copyright | ||
|
|
||
| slices: | ||
| src-with-tests: | ||
| essential: | ||
| - golang-1.25-src_src-with-tests | ||
| contents: | ||
| /usr/share/go: # Symlink to go-1.25 | ||
|
|
||
| copyright: | ||
| contents: | ||
| /usr/share/doc/golang-src/copyright: |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed,
dist-tools,doc-toolsandgo-build-srcare now part of thegobinary, yes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as well as
pprof,covdataandtest2json?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.