feat(26.04): introduce v3 format#903
feat(26.04): introduce v3 format#903cjdcordeiro wants to merge 21 commits intocanonical:ubuntu-26.04from
Conversation
lczyk
left a comment
There was a problem hiding this comment.
i know this is still in draft mode, but i thought i'd have a look anyway
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Updated libx11-6_libs and ocl-icd-libopencl1_libs to use a new format.
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
There was a problem hiding this comment.
syntax errors in: EDIT: fixed while i was posting the review, but the bit below is still valid
- slices/libpython3.13-stdlib.yaml
- slices/libsnappy1v5.yaml
- slices/libsubid5.yaml
- slices/libtiff6.yaml
- slices/libvdpau1.yaml
- slices/mesa-libgallium.yaml
- slices/perl-base.yaml
- slices/rabbitmq-server.yaml
- slices/tar.yaml
- slices/util-linux.yaml
also, i'd fix those too, just so people are not confused when they find them in the comments:
$ find slices -type f -name '*.yaml' | xargs grep -nEH '\s{6}#\s-\s[^\s-]'
slices/rabbitmq-server.yaml:26: # - erlang-base_bins
slices/rabbitmq-server.yaml:27: # - erlang-inets_scripts
slices/rabbitmq-server.yaml:28: # - erlang-inets_modules
slices/rabbitmq-server.yaml:29: # - erlang-os-mon_bins
slices/nginx.yaml:11: # - iproute2_bins
slices/libsubid5.yaml:14: # - libcrypt1_libs
slices/libsubid5.yaml:15: # - libpam0g_libs
slices/libsubid5.yaml:17: # - libsemanage2_libs
slices/gcc.yaml:14: # - gcc (priority 20)
slices/gcc.yaml:15: # - clang (priority 10)
slices/gcc.yaml:16: # - tcc (priority 10)
slices/gcc.yaml:17: # - pcc (priority -100)
slices/openssl-provider-legacy.yaml:10: # - libssl3t64_libs # prevent circular dependency with libssl3t64
slices/libboost-coroutine1.83.0.yaml:11: # - libgcc-s1_libs
slices/ca-certificates-java.yaml:13: # - openjdk-8-jre-headless_security
see 30a3da8 |
lczyk
left a comment
There was a problem hiding this comment.
approving subject to CI passing and https://github.com/canonical/chisel-releases/pull/903/files#r2832716434 ( i've missed one case in my sed suggestion )
|
in fear of showing how bad my $ find slices -type f -name '*.yaml' | \
xargs -I{} -n1 bash -c \
'yq -r \'.slices | .[] | select(.essential != null) | .essential | tag\' {} | grep -q \'!!seq\' && echo {}'
slices/libnginx-mod-stream-geoip.yaml
slices/libnginx-mod-http-geoip.yaml
slices/libglib2.0-0t64.yaml
slices/libnss3.yaml
slices/libnginx-mod-stream-geoip2.yaml
slices/tzdata-legacy.yaml
slices/libnginx-mod-stream.yaml
slices/libnginx-mod-http-headers-more-filter.yaml
slices/libnginx-mod-http-geoip2.yaml☝️ all the files with non-map essentials |
|
zhijie-yang
left a comment
There was a problem hiding this comment.
Here are some non-v3-essentials remaining in the ready-to-drop-in comments that we need to also deal with.
Co-authored-by: zhijie-yang <zhijie.yang@canonical.com>
Co-authored-by: zhijie-yang <zhijie.yang@canonical.com>
|
the hint validation is failing due to the lack of checkout of the forked head. i'm working on a fix |
Related to canonical/chisel#249
Needs #904
IMPORTANT
For the reviewer: please note that the huge changeset is brought in by the commit 84f4eb3, which is about converting all essentials to maps, according to the v1.4.0+v3 expectations