Skip to content

Comments

feat(26.04): introduce v3 format#903

Open
cjdcordeiro wants to merge 21 commits intocanonical:ubuntu-26.04from
cjdcordeiro:v3
Open

feat(26.04): introduce v3 format#903
cjdcordeiro wants to merge 21 commits intocanonical:ubuntu-26.04from
cjdcordeiro:v3

Conversation

@cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Feb 12, 2026

Related to canonical/chisel#249

Needs #904

IMPORTANT

For the reviewer: please note that the huge changeset is brought in by the commit 84f4eb3, which is about converting all essentials to maps, according to the v1.4.0+v3 expectations

@cjdcordeiro
Copy link
Collaborator Author

@upils @letFunny

@cjdcordeiro cjdcordeiro marked this pull request as draft February 12, 2026 15:57
@cjdcordeiro cjdcordeiro mentioned this pull request Feb 12, 2026
3 tasks
@ROCKsBot ROCKsBot requested a review from a team February 13, 2026 01:40
@lczyk lczyk added the Blocked Waiting for something external label Feb 19, 2026
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is still in draft mode, but i thought i'd have a look anyway

@cjdcordeiro cjdcordeiro requested a review from lczyk February 20, 2026 07:32
@cjdcordeiro cjdcordeiro removed the Blocked Waiting for something external label Feb 20, 2026
@cjdcordeiro cjdcordeiro marked this pull request as ready for review February 20, 2026 10:38
cjdcordeiro and others added 3 commits February 20, 2026 12:04
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax errors in: EDIT: fixed while i was posting the review, but the bit below is still valid

- slices/libpython3.13-stdlib.yaml
- slices/libsnappy1v5.yaml
- slices/libsubid5.yaml
- slices/libtiff6.yaml
- slices/libvdpau1.yaml
- slices/mesa-libgallium.yaml
- slices/perl-base.yaml
- slices/rabbitmq-server.yaml
- slices/tar.yaml
- slices/util-linux.yaml

also, i'd fix those too, just so people are not confused when they find them in the comments:

$ find slices -type f -name '*.yaml' | xargs grep -nEH '\s{6}#\s-\s[^\s-]'
slices/rabbitmq-server.yaml:26:      # - erlang-base_bins
slices/rabbitmq-server.yaml:27:      # - erlang-inets_scripts
slices/rabbitmq-server.yaml:28:      # - erlang-inets_modules
slices/rabbitmq-server.yaml:29:      # - erlang-os-mon_bins
slices/nginx.yaml:11:      # - iproute2_bins
slices/libsubid5.yaml:14:      # - libcrypt1_libs
slices/libsubid5.yaml:15:      # - libpam0g_libs
slices/libsubid5.yaml:17:      # - libsemanage2_libs
slices/gcc.yaml:14:      # - gcc (priority 20)
slices/gcc.yaml:15:      # - clang (priority 10)
slices/gcc.yaml:16:      # - tcc (priority 10)
slices/gcc.yaml:17:      # - pcc (priority -100)
slices/openssl-provider-legacy.yaml:10:      # - libssl3t64_libs # prevent circular dependency with libssl3t64
slices/libboost-coroutine1.83.0.yaml:11:      # - libgcc-s1_libs
slices/ca-certificates-java.yaml:13:      # - openjdk-8-jre-headless_security

@cjdcordeiro
Copy link
Collaborator Author

syntax errors in: EDIT: fixed while i was posting the review, but the bit below is still valid

- slices/libpython3.13-stdlib.yaml
- slices/libsnappy1v5.yaml
- slices/libsubid5.yaml
- slices/libtiff6.yaml
- slices/libvdpau1.yaml
- slices/mesa-libgallium.yaml
- slices/perl-base.yaml
- slices/rabbitmq-server.yaml
- slices/tar.yaml
- slices/util-linux.yaml

also, i'd fix those too, just so people are not confused when they find them in the comments:

$ find slices -type f -name '*.yaml' | xargs grep -nEH '\s{6}#\s-\s[^\s-]'
slices/rabbitmq-server.yaml:26:      # - erlang-base_bins
slices/rabbitmq-server.yaml:27:      # - erlang-inets_scripts
slices/rabbitmq-server.yaml:28:      # - erlang-inets_modules
slices/rabbitmq-server.yaml:29:      # - erlang-os-mon_bins
slices/nginx.yaml:11:      # - iproute2_bins
slices/libsubid5.yaml:14:      # - libcrypt1_libs
slices/libsubid5.yaml:15:      # - libpam0g_libs
slices/libsubid5.yaml:17:      # - libsemanage2_libs
slices/gcc.yaml:14:      # - gcc (priority 20)
slices/gcc.yaml:15:      # - clang (priority 10)
slices/gcc.yaml:16:      # - tcc (priority 10)
slices/gcc.yaml:17:      # - pcc (priority -100)
slices/openssl-provider-legacy.yaml:10:      # - libssl3t64_libs # prevent circular dependency with libssl3t64
slices/libboost-coroutine1.83.0.yaml:11:      # - libgcc-s1_libs
slices/ca-certificates-java.yaml:13:      # - openjdk-8-jre-headless_security

see 30a3da8

@cjdcordeiro cjdcordeiro requested a review from lczyk February 20, 2026 11:14
Copy link
Collaborator

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving subject to CI passing and https://github.com/canonical/chisel-releases/pull/903/files#r2832716434 ( i've missed one case in my sed suggestion )

@lczyk
Copy link
Collaborator

lczyk commented Feb 20, 2026

in fear of showing how bad my jq/yq jiujitsu is:

$ find slices -type f -name '*.yaml' | \
xargs -I{} -n1 bash -c \
'yq -r \'.slices | .[] | select(.essential != null) | .essential | tag\' {} | grep -q \'!!seq\' && echo {}'
slices/libnginx-mod-stream-geoip.yaml
slices/libnginx-mod-http-geoip.yaml
slices/libglib2.0-0t64.yaml
slices/libnss3.yaml
slices/libnginx-mod-stream-geoip2.yaml
slices/tzdata-legacy.yaml
slices/libnginx-mod-stream.yaml
slices/libnginx-mod-http-headers-more-filter.yaml
slices/libnginx-mod-http-geoip2.yaml

☝️ all the files with non-map essentials

@lczyk
Copy link
Collaborator

lczyk commented Feb 20, 2026

sigh... 😑 i forgot that merging #907 would mess up this PR. my merge so my fix: 7a13277, 70ab5b5

@lczyk lczyk changed the title feat: introduce v3 format in 26.04 feat(26.04): introduce v3 format Feb 20, 2026
@lczyk lczyk self-requested a review February 20, 2026 20:17
@cjdcordeiro cjdcordeiro requested a review from upils February 23, 2026 17:24
@lczyk lczyk added Blocked Waiting for something external Priority Look at me first labels Feb 24, 2026
@lczyk
Copy link
Collaborator

lczyk commented Feb 24, 2026

@lczyk lczyk mentioned this pull request Feb 24, 2026
3 tasks
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some non-v3-essentials remaining in the ready-to-drop-in comments that we need to also deal with.

cjdcordeiro and others added 3 commits February 24, 2026 10:17
Co-authored-by: zhijie-yang <zhijie.yang@canonical.com>
Co-authored-by: zhijie-yang <zhijie.yang@canonical.com>
@cjdcordeiro
Copy link
Collaborator Author

the hint validation is failing due to the lack of checkout of the forked head. i'm working on a fix

@cjdcordeiro cjdcordeiro removed the Blocked Waiting for something external label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority Look at me first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants