-
Notifications
You must be signed in to change notification settings - Fork 1k
ci: resolute rust-based gpg-sq rejects short GPG keyids #6710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: resolute rust-based gpg-sq rejects short GPG keyids #6710
Conversation
holmanb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include example error message for future reference. Otherwise, this looks good to me.
I'm guessing we need to update some documentation since this is a UI change, right?
caab93b to
326c416
Compare
|
Dismissing review due to failing tests. |
doc/examples/cloud-config-apt.txt
Outdated
| # The values inside the entries consist of the following optional entries: | ||
| # 'source': a sources.list entry (some variable replacements apply) | ||
| # 'keyid': providing a key to import via shortid or fingerprint | ||
| # 'keyid': providing a key to import via longid or fingerprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The term "longid" is not well-defined.
doc/examples/cloud-config-apt.txt
Outdated
| # Additionally, if the repository requires a custom signing key, it can be | ||
| # specified via the same fields as for custom sources: | ||
| # 'keyid': providing a key to import via shortid or fingerprint | ||
| # 'keyid': providing a key to import via longid or fingerprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 16-bit ID. The 'long' version from the gpg --list-keys --keyid-format section of the gpg man-page
Select how to display key IDs. "short" is the traditional 8-character key ID.
"long" is the more accurate (but less convenient) 16-character key ID.
Add an "0x" to either to include an "0x" at the beginning of the key ID, as in 0x99242560.
Use long-keyid for testing to avoid non-zero exit codes warning of insecure short IDs in gpg (GnuPG-compatible Sequoia Chameleon) 2.2.40.
326c416 to
b4ae6f9
Compare
e07fcd9 to
56f74ac
Compare
Proposed Commit Message
Additional Context
Success run on questing:
https://github.com/blackboxsw/cloud-init/actions/runs/21609823450/job/62275681732
Success run on resolute:
https://github.com/blackboxsw/cloud-init/actions/runs/21610228334/job/62277053444
Test Steps
Merge type