Skip to content

Conversation

@holmanb
Copy link
Member

@holmanb holmanb commented Feb 5, 2026

Proposed Commit Message

chore: auto-format shell

Make `tox` -e do_format` and `tox -e check_format` enforce
formatting of json and shell scripts.

Remove unmaintained shell scripts.

Update GH Actions.

Additional Context

Improves consistency.

This uses flags that resemble the existing format, which reduces diff size. One exception to this rule is using --space-redirects, which I believe improves legibility.

This makes no functional changes to the code.

If this is agreeable, I'll propose a followup to the ubuntu/devel branch with the same for ./debian/*.

Test Steps

  1. snap install shfmt
  2. Undo a formatting change in a shell script or json
  3. Run tox -e check_format <- should fail
  4. Run tox -e do_format <- should succeed
  5. Run tox -e check_format <- should succeed

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Also add a tox command to run this.

```
shfmt --list --case-indent --indent=4 --space-redirects -w
```

Using v3.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants