fix:(disk_setup):handle empty disk in check_partition_gpt_layout_sfdisk #6728
+26
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking GPT partition layout using sfdisk, handle the case where a disk has no partition table yet.
Previously, it would raise an exception.
Because check_partition_gpt_layout_sfdisk calls "sfdisk -l -J ", the command exits with code 1 and the error "does not contain a recognized partition table". The code doesn't handle it and raises an error.
Now it returns an empty list.
I also add unit test to cover this empty disk scenario.
Fixes GH-6682
Test Steps
I run test on OpenStack with an additional empty disk with config data as below
steps
After fix, no unexpected error about sfdisk, and the additional disk /dev/vdb is parted
Merge type