feat: allow use of interceptable mknod in ProviderService
#607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
Author
|
Failing integration tests will be fixed by #587 |
mattculler
commented
Jan 16, 2025
pyproject.toml
Outdated
Comment on lines
12
to
13
| "craft-providers @ git+https://github.com/canonical/craft-providers.git@work/CRAFT-2568-settable-mknod-intercept", | ||
| #"craft-providers>=2.1.0", |
Contributor
Author
There was a problem hiding this comment.
Reminder to future self: update this once I release a new craft-providers.
mr-cal
requested changes
Jan 16, 2025
Contributor
mr-cal
left a comment
mr-cal
left a comment
There was a problem hiding this comment.
I'd like to see unit tests for the logic, otherwise looks good. Thanks for filling out the docstrings.
| with check: | ||
| mock_provider.assert_called_once_with( | ||
| lxd_project="testcraft", lxd_remote=lxd_remote | ||
| lxd_project="testcraft", lxd_remote=lxd_remote, intercept_mknod=True |
Contributor
There was a problem hiding this comment.
Can you exercise the default value and setting ProviderService(intercept_mknod)?
A quick way to do this would be to instantiate a ProviderService like some of the other tests and add something along the lines of @pytest.param("intercept_mknod", [None, True, False])
upils
requested changes
Jan 17, 2025
mattculler
force-pushed
the
work/CRAFT-2568-settable-mknod-intercept
branch
from
456fb52 to
9f8c5b4
Compare
mattculler
force-pushed
the
work/CRAFT-2568-settable-mknod-intercept
branch
from
9f8c5b4 to
8461153
Compare
Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?Make use of
craft_providers's newintercept_mknodargument toLXDProvider.canonical/craft-providers#717