test(spread): speed up the skip-retest spread test #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't restart the container between pack runs and do the clean during restore.
bepri
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the skip-repack spread test by eliminating unnecessary container restarts and reorganizing cleanup operations. The changes reduce test execution time while maintaining the same test coverage.
Key changes:
- Configure idle timeout to avoid container restarts between pack runs
- Move cleanup operation from execute to restore phase
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
* Initial plan * Move repack-test directory creation to prepare phase Co-authored-by: lengau <4305943+lengau@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lengau <4305943+lengau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint && make test?docs/reference/changelog.rst)?Don't restart the container between pack runs and do the clean during restore.
I found this while I was doing some unrelated work on the spread tests.