fix: check for root user as early as possible in landscape-config#397
Draft
jmucc wants to merge 2 commits intocanonical:mainfrom
Draft
fix: check for root user as early as possible in landscape-config#397jmucc wants to merge 2 commits intocanonical:mainfrom
jmucc wants to merge 2 commits intocanonical:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the root user check in landscape-config to execute earlier in the execution flow, ensuring the program fails fast with a clear error message before attempting any operations that would fail anyway due to insufficient privileges.
Key Changes:
- Root user validation now occurs immediately after configuration parsing, before any initialization or bootstrap operations
- Test setup updated to mock
os.getuid()to return 0 (root) to ensure tests continue passing with the earlier validation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| landscape/client/configuration.py | Moved root user check from after registration logic to immediately after config parsing and before logging initialization |
| landscape/client/tests/test_configuration.py | Added os.getuid mocks in test setup classes to simulate root user for existing tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
landscape-configmust be run as root. We should check that the user is root before trying any operations that would fail anyway.