refactor: inline broadcast_event in broker server#401
Draft
srunde3 wants to merge 1 commit intocanonical:mainfrom
Draft
refactor: inline broadcast_event in broker server#401srunde3 wants to merge 1 commit intocanonical:mainfrom
srunde3 wants to merge 1 commit intocanonical:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
@eventdecorator changed the function signature of the methods it decorated, and this obfuscated the arguments that the event should accept. IMO it is an unnecessary abstraction.This is a small step towards better understanding the event system in the client. In the future I'd like to type the events (e.g., enum) in the future so that we can better reason about event senders and receivers.