fix: restore functionality and tests for python 3.14#406
Merged
jmucc merged 3 commits intocanonical:mainfrom Feb 5, 2026
Merged
fix: restore functionality and tests for python 3.14#406jmucc merged 3 commits intocanonical:mainfrom
jmucc merged 3 commits intocanonical:mainfrom
Conversation
Perfect5th
approved these changes
Feb 5, 2026
Contributor
Perfect5th
left a comment
Perfect5th
left a comment
There was a problem hiding this comment.
LGTM. Test pass (often enough) and it's backwards compatible with earlier versions of Python, afaict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolute uses python3.14, we need to ensure the tests pass, or else landscape client will not be able to build for the archive.
Verify these tests fail or are flaky when running on python3.14, then check out these changes, and observe that the tests are consistently passing.
Also run
make checka few times and ensure there are no failures or errors.