input::CursorObserver: Add image_set_to observation
#4579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAOF
force-pushed
the
cursor-observer-observes-cursor-images
branch
from
2dc5a64 to
0c524cf
Compare
AlanGriffiths
approved these changes
Dec 18, 2025
|
|
||
| void mi::CursorObserverMultiplexer::image_set_to(std::shared_ptr<graphics::CursorImage> cursor) | ||
| { | ||
| for_each_observer(&CursorObserver::image_set_to, std::move(cursor)); |
Contributor
There was a problem hiding this comment.
Is there any value to std::move() here?
Contributor
There was a problem hiding this comment.
I approved: I think this is just a distraction
This notifies observers when the cursor image changes.
We've added a virtual member to CursorObserver; that's an ABI break.
Saviq
force-pushed
the
cursor-observer-observes-cursor-images
branch
from
0c524cf to
29bd7de
Compare
TICS Quality Gate✔️ Passedmir
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
This allows `CursorObserver`s to monitor when the cursor image changes. Adds a new virtual method to `CursorObserver`, which breaks ABI, so this also bumps the mirserver ABI as that hasn't been done yet this release. ## Checklist - [x] Tests added and pass - [x] Adequate documentation added - [ ] (optional) Added Screenshots or videos
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
CursorObservers to monitor when the cursor image changes.Adds a new virtual method to
CursorObserver, which breaks ABI, so this also bumps the mirserver ABI as that hasn't been done yet this release.Checklist