Fix/logging snprintf negative time 4556 #4593
Open
+62
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarek-y-ismail
requested changes
Jan 5, 2026
Contributor
tarek-y-ismail
left a comment
tarek-y-ismail
left a comment
There was a problem hiding this comment.
Looks good. One small nit...
AlanGriffiths
requested changes
Jan 5, 2026
Contributor
AlanGriffiths
left a comment
AlanGriffiths
left a comment
There was a problem hiding this comment.
Some tweaks and some non-blocking comments you can chose to ignore
tarek-y-ismail
requested changes
Jan 6, 2026
Contributor
tarek-y-ismail
left a comment
tarek-y-ismail
left a comment
There was a problem hiding this comment.
CI is failing. The following suggestion might help you fix it.
…hub.com/DigraJatin/mir into fix/logging-snprintf-negative-time-4556
auto-merge was automatically disabled
January 6, 2026 20:59
Head branch was pushed to by a user without write access
tarek-y-ismail
approved these changes
Jan 8, 2026
Contributor
tarek-y-ismail
left a comment
tarek-y-ismail
left a comment
There was a problem hiding this comment.
Looking good! Now let's see if CI is happy.
tarek-y-ismail
requested changes
Jan 8, 2026
…hub.com/DigraJatin/mir into fix/logging-snprintf-negative-time-4556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4556
What's new?
Past values will be printed like -
500 ms agoFuture values will be printed like -
100 ms in futureHow to test
Added unit tests for the function, run
./bin/mir_unit_tests --gtest_filter=TimestampTest.*and verify.Checklist