feat: add support for passing "all" arg to snap.logs#166
Closed
PietroPasotti wants to merge 1 commit intocanonical:mainfrom
Closed
feat: add support for passing "all" arg to snap.logs#166PietroPasotti wants to merge 1 commit intocanonical:mainfrom
PietroPasotti wants to merge 1 commit intocanonical:mainfrom
Conversation
james-garner-canonical
approved these changes
Aug 19, 2025
Contributor
james-garner-canonical
left a comment
There was a problem hiding this comment.
Looks good to me, please bump LIBPATCH if you want to have this fix released after merging.
Collaborator
|
@james-garner-canonical Can we close this and move the PR to https://github.com/canonical/charmlibs/tree/main/snap? |
Contributor
|
Closing in favour of canonical/charmlibs#250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
snap logscommand supports anallparameter for the-nflag.This PR adds support for that (in the form of a type hint correction, the implementation is unchanged).