Skip to content

feat: add support for passing "all" arg to snap.logs#166

Closed
PietroPasotti wants to merge 1 commit intocanonical:mainfrom
PietroPasotti:feat/allow-logs-all
Closed

feat: add support for passing "all" arg to snap.logs#166
PietroPasotti wants to merge 1 commit intocanonical:mainfrom
PietroPasotti:feat/allow-logs-all

Conversation

@PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Aug 19, 2025

the snap logs command supports an all parameter for the -n flag.

# from the command's own --help:
[logs command options]
          --abs-time   Display absolute times (in RFC 3339 format). Otherwise, display relative times up to 60 days, then YYYY-MM-DD.
      -n=              Show only the given number of lines, or 'all'. (default: 10)
      -f               Wait for new lines and print them as they come in.

This PR adds support for that (in the form of a type hint correction, the implementation is unchanged).

@PietroPasotti PietroPasotti changed the title added support for passing "all" arg to snap.logs feat: add support for passing "all" arg to snap.logs Aug 19, 2025
Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please bump LIBPATCH if you want to have this fix released after merging.

@benhoyt
Copy link
Collaborator

benhoyt commented Nov 4, 2025

@james-garner-canonical Can we close this and move the PR to https://github.com/canonical/charmlibs/tree/main/snap?

@james-garner-canonical
Copy link
Contributor

Closing in favour of canonical/charmlibs#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants