Conversation
13 tasks
27b2f30 to
4f1d479
Compare
a514541 to
74848dd
Compare
alesancor1
reviewed
Oct 1, 2025
rust-rock/1.84-25.04/apt-shim.sh
Outdated
Member
There was a problem hiding this comment.
Ok, in any case, why do we need apt in the rock?
2 tasks
Collaborator
Author
|
also confirmed with @cjdcordeiro that yes, we can PR an edge rock (built from my own repos, rather than merged slices) and then update once slices are merged |
3 tasks
Collaborator
Author
|
based on @zhijie-yang's suggestions i've removed apt-bootstrap and changed it to a normal apt slice. i've also explicitly included coreutils since this is an SDK rock |
9dc1637 to
f021a1f
Compare
97374a1 to
eb28e84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the rust rock for 25.04. It is a culmination of much work in chisel releases (see below). The tests here broadly follow the tests for individual slices in chisel releases.
#633 - ROCKS-2270/libc6-dev-for-25.04(merged)└ #644 - ROCKS-2270/binutils-for-25.04(merged)....└ #648 - ROCKS-2270/cpp-for-25.04(merged)........└ #649 - ROCKS-2270/gcc-14-for-25.04
............└ #610 - ROCKS-2271/rust-1.84-25.04
................└ #634 - ROCKS-2271/cargo-1.84-25.04
....................└ #3 - ROCKS-2271/rust-rock-25.04 (this PR)
For now the rockcraft.yaml uses the
lczyk/chisel-releases/ROCKS-2271/cargo-1.84-25.04branch. This will be updated to the mainchisel-releasesbranch once the PRs above are reviewed and merged.