Skip to content

Comments

feat(25.04): rust 1.84 for 25.04#3

Merged
lczyk merged 59 commits intomainfrom
ROCKS-2271/rust-rock-25.04
Oct 6, 2025
Merged

feat(25.04): rust 1.84 for 25.04#3
lczyk merged 59 commits intomainfrom
ROCKS-2271/rust-rock-25.04

Conversation

@lczyk
Copy link
Collaborator

@lczyk lczyk commented Sep 16, 2025

This PR adds the rust rock for 25.04. It is a culmination of much work in chisel releases (see below). The tests here broadly follow the tests for individual slices in chisel releases.

#633 - ROCKS-2270/libc6-dev-for-25.04 (merged)
#644 - ROCKS-2270/binutils-for-25.04 (merged)
....└ #648 - ROCKS-2270/cpp-for-25.04 (merged)
........└ #649 - ROCKS-2270/gcc-14-for-25.04
............└ #610 - ROCKS-2271/rust-1.84-25.04
................└ #634 - ROCKS-2271/cargo-1.84-25.04
....................└ #3 - ROCKS-2271/rust-rock-25.04 (this PR)

For now the rockcraft.yaml uses the lczyk/chisel-releases/ROCKS-2271/cargo-1.84-25.04 branch. This will be updated to the main chisel-releases branch once the PRs above are reviewed and merged.

@lczyk lczyk force-pushed the ROCKS-2271/rust-rock-25.04 branch from 27b2f30 to 4f1d479 Compare September 29, 2025 10:42
@lczyk lczyk force-pushed the ROCKS-2271/rust-rock-25.04 branch from a514541 to 74848dd Compare September 29, 2025 13:59
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, in any case, why do we need apt in the rock?

@lczyk
Copy link
Collaborator Author

lczyk commented Oct 1, 2025

also confirmed with @cjdcordeiro that yes, we can PR an edge rock (built from my own repos, rather than merged slices) and then update once slices are merged

@lczyk
Copy link
Collaborator Author

lczyk commented Oct 2, 2025

based on @zhijie-yang's suggestions i've removed apt-bootstrap and changed it to a normal apt slice. i've also explicitly included coreutils since this is an SDK rock

@lczyk lczyk force-pushed the ROCKS-2271/rust-rock-25.04 branch from 9dc1637 to f021a1f Compare October 2, 2025 22:15
@lczyk lczyk force-pushed the ROCKS-2271/rust-rock-25.04 branch from 97374a1 to eb28e84 Compare October 3, 2025 00:03
@lczyk lczyk self-assigned this Oct 3, 2025
@lczyk lczyk merged commit 82ffe14 into main Oct 6, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants