-
Notifications
You must be signed in to change notification settings - Fork 73
fix: change the go module name to canonical/spread #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes canonical#240, which was introduced with canonical#238 Signed-off-by: Alex Lowe <alex.lowe@canonical.com>
|
Closing and reopening to (hopefully) re-trigger CI now that the Google outage appears to be over. |
lczyk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. i've confirmed that these are all the occurrences of 'snapcore' and that the package installs correctly when checked out from the work/240 branch.
i'm running on aarch64 so will be using this commit to build for now, since the snap version is amd64 only.
toabctl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried the change and worked for me
also, ci still failing, now with, somewhat amusing, |
|
@cmatsuoka mind taking a look at this? |
😑 |
Fixes #240, which was introduced with #238