Extend range of supported ssh algorithms #245
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest version of golang.org/x/crypto/ssh to add support of latest algorithms. At the same time use ssh.InsecureAlgorithms to support both ancient Ubuntu 14.04-era systems and daily Gentoo systems equally. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SSH client configuration to support a broader range of SSH algorithms by upgrading to the latest version of golang.org/x/crypto/ssh and implementing a fallback mechanism for older systems.
- Updates golang.org/x/crypto and related dependencies to their latest versions
- Introduces
allAlgorithms()function that combines secure and insecure SSH algorithms for compatibility - Modifies SSH client configurations in both
client.goandopenstack.goto use the extended algorithm sets
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spread/client.go | Adds allAlgorithms() helper function and updates Dial() to use extended SSH algorithm configuration |
| spread/openstack.go | Updates waitServerBootSSH() to use the new algorithm configuration for OpenStack server connections |
| go.mod | Upgrades golang.org/x/crypto and related dependencies to latest versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| insecure := ssh.InsecureAlgorithms() | ||
|
|
||
| // Old systems may require old, insecure crypto, to connect. | ||
| // Prefer a secure algorithms by placing them earlier in the list. |
There was a problem hiding this comment.
The comment contains a grammatical error. It should be 'Prefer secure algorithms' instead of 'Prefer a secure algorithms'.
Suggested change
| // Prefer a secure algorithms by placing them earlier in the list. | |
| // Prefer secure algorithms by placing them earlier in the list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest version of golang.org/x/crypto/ssh to add support of latest algorithms. At the same time use ssh.InsecureAlgorithms to support both ancient Ubuntu 14.04-era systems and daily Gentoo systems equally.