wlcs.pc: Add a “test revisions” variable section #398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used by consumers of wlcs to detect when a test is fixed to more correctly validate protocol behaviour, and so when it might be expected to fail on correct implementations.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a test revision tracking mechanism in the pkg-config file to help downstream consumers identify when WLCS tests are updated to more correctly validate protocol compliance. This allows compositors to know when a previously passing test may start failing due to stricter correctness checks rather than actual regressions.
Key changes:
- Added documentation section explaining the test revision system
- Introduced first test revision variable for
BadBufferTest.test_truncated_shm_file
3 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
TICS Quality Gate✔️ PassedNo changed files applicable for TICS analysis quality gating. TICS / TICS / Run TICS analysis |
Contributor
|
I'm not at all convinced we need this level of granularity. This seems more like something to highlight in the release notes - and would be more discoverable there. For our internal detection, bumping the wlcs version on main after branching a release would allow us to accommodate the new behaviour |
Contributor
Author
|
Solved by just bumping the WLCS version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used by consumers of wlcs to detect when a test is fixed to more correctly validate protocol behaviour, and so when it might be expected to fail on correct implementations.
Set the revision of
BadBufferTest.test_truncated_shm_fileto 1, asthis is the first test we have to use this feature on.