hack: Ensure surfaces aren't entirely occluded by cursor #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our tests tend to wait for a `surface.frame` event to ensure that a surface has been mapped. Unfortunately, this is not always accurate. Particularly: if a surface is entirely occluded by another (or by the cursor) then a new frame is not required and the compositor will not send a `surface.frame` event even once the surface *is* mapped. Because plumbing surface introspection through the WLCS hooks is going to be a longer-term project, just ensure that the surfaces that hit this problem are definitely not occluded by the cursor.
Contributor
Author
|
Closed in favour of just not displaying the cursor image. |
TICS Quality Gate✔️ PassedNo changed files applicable for TICS analysis quality gating. TICS / TICS / Run TICS analysis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests tend to wait for a
surface.frameevent to ensure that a surface has been mapped.Unfortunately, this is not always accurate. Particularly: if a surface is entirely occluded by another (or by the cursor) then a new frame is not required and the compositor will not send a
surface.frameevent even once the surface is mapped.Because plumbing surface introspection through the WLCS hooks is going to be a longer-term project, just ensure that the surfaces that hit this problem are definitely not occluded by the cursor.