close #152 accepts IEnumerable<KeyValuePair<,>> for QueryMap#228
Open
donnytian wants to merge 2 commits intocanton7:developfrom
Open
close #152 accepts IEnumerable<KeyValuePair<,>> for QueryMap#228donnytian wants to merge 2 commits intocanton7:developfrom
donnytian wants to merge 2 commits intocanton7:developfrom
Conversation
added 2 commits
June 10, 2022 23:11
…nstead of IDictionary<,>
Author
|
@canton7 CI failed due to package validation, not sure how we can fix this, can we just upgrade the baseline version or just remove it temporarily? Can you please help with that? |
Owner
|
I'm afraid I wasn't expecting this and I'm going to be tied up for the next week or two on other things, and this will have to wait. Sorry! |
Owner
|
Apologies for the delay. This looks great, thanks! You can squish the package validation warnings with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Proposed:
IDictionary<TKey, TValue>toIEnumerable<KeyValuePair<TKey, TValue>>forRequestInfo.AddQueryMap(...)andRequestInfo.AddQueryCollectionMap(...)